GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-126222: Fix `_PyUop_num_popped` by markshannon · Pull Request #126507 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Nov 6, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: JIT error stubs don't account for peeks #126222

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markshannon added 3 commits November 6, 2024 16:29
@markshannon
Add failing test
a87752c
@markshannon
Do not include peeks in uop pop effect
98f6f0f
@markshannon
Add news
a8771ab
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 6, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 6, 2024
JIT error stubs don't account for peeks #126222
Closed
@markshannon
markshannon requested a review from brandtbucher November 6, 2024 17:14
brandtbucher
brandtbucher approved these changes Nov 6, 2024
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 6, 2024
@markshannon
markshannon merged commit 85036c8 into python:main Nov 7, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 7, 2024
@markshannon
markshannon deleted the fix-num-popped-pushed branch November 18, 2024 14:36
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@markshannon @picnixz
pythonGH-126222: Fix _PyUop_num_popped (pythonGH-126507)
4b242ec
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@markshannon @ebonnal
pythonGH-126222: Fix _PyUop_num_popped (pythonGH-126507)
29ad416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@markshannon @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.