GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126332: Fix pyrepl crash for double ctrl-z in line overflow by eendebakpt · Pull Request #126650 · python/cpython

Conversation

@eendebakpt

@eendebakpt eendebakpt commented Nov 10, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Notes:

  • Fix crash of pyrepl in windows when a double ctrl-z is entered on an overflowing line.
  • The fix can also be put into the str_width method instead of the wlen method. Both of these are not documented, so I am not sure whether one location should be preferred over the other.
  • Issue: 3.13.0 REPL crashes on double ctrl+z in line overflow #126332

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
devdanzin reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@eendebakpt
Fix pyrepl crash for double ctrl-z in line overflow
7dfa24e
@eendebakpt
eendebakpt requested review from ambv, lysnikolaou and pablogsal as code owners November 10, 2024 19:41
@bedevere-app bedevere-app Bot added the awaiting review label Nov 10, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 10, 2024
3.13.0 REPL crashes on double ctrl+z in line overflow #126332
Closed
blurb-it Bot and others added 4 commits November 10, 2024 19:45
@blurb-it
📜🤖 Added by blurb_it.
75e909e
@eendebakpt
Merge branch 'main' into pyrepl_ctrl_z
99ea8af
@eendebakpt
Merge branch 'main' into pyrepl_ctrl_z
7a9033a
@eendebakpt
Merge branch 'main' into pyrepl_ctrl_z
c82d153
vstinner
vstinner reviewed Jan 19, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a new Lib/test/test_pyrepl/test_utils.py file and add tests on wlen() and str_width() functions?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
eendebakpt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@eendebakpt eendebakpt mentioned this pull request Jan 21, 2025
weird ctrl z crash in terminal #129114
Closed
@pablogsal

pablogsal commented Jan 21, 2025

Copy link
Copy Markdown
Member

Would it be possible to add a new Lib/test/test_pyrepl/test_utils.py file and add tests on wlen() and str_width() functions?

I think we should do this in a separate PR. @eendebakpt do you want to open a PR for that?
eendebakpt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal added the needs backport to 3.13 only security fixes label Jan 21, 2025
@pablogsal
pablogsal merged commit d147e5e into python:main Jan 21, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 21, 2025

Copy link
Copy Markdown

Thanks @eendebakpt for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Jan 21, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 21, 2025
@eendebakpt @blurb-it @miss-islington
pythongh-126332: Fix pyrepl crash for double ctrl-z in line overflow (p…
91eb997 
…ythonGH-126650)

(cherry picked from commit d147e5e)

Co-authored-by: Pieter Eendebak <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Jan 21, 2025

Copy link
Copy Markdown

GH-129154 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 21, 2025
pablogsal pushed a commit that referenced this pull request Jan 21, 2025
@miss-islington @eendebakpt @blurb-it
[3.13] gh-126332: Fix pyrepl crash for double ctrl-z in line overflow (…
0c70453 
…GH-126650) (#129154)

gh-126332: Fix pyrepl crash for double ctrl-z in line overflow (GH-126650)

(cherry picked from commit d147e5e)

Co-authored-by: Pieter Eendebak <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
@eendebakpt

eendebakpt commented Jan 26, 2025

Copy link
Copy Markdown
Contributor Author

@pablogsal I added some tests in #129325
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@eendebakpt @pablogsal @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.