GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-117759: Update GC docs for incremental collection by markshannon · Pull Request #126695 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Nov 11, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Document the new incremental GC #117759

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@markshannon
Update GC docs
65d4042
@markshannon markshannon added the skip news label Nov 11, 2024
@markshannon markshannon changed the title Update GC docs GH-117759: Update GC docs for incremental collection Nov 11, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 11, 2024
Document the new incremental GC #117759
Closed
3 tasks done
@markshannon
markshannon requested a review from iritkatriel November 11, 2024 18:21
@markshannon
markshannon marked this pull request as ready for review November 11, 2024 18:24
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 11, 2024
danielhollas
danielhollas reviewed Nov 11, 2024
View reviewed changes
Comment thread InternalDocs/garbage_collector.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@markshannon @danielhollas
Update InternalDocs/garbage_collector.md
e2ff3fd
Co-authored-by: Daniel Hollas <[email protected]>
iritkatriel
iritkatriel reviewed Nov 12, 2024
View reviewed changes
Comment thread InternalDocs/garbage_collector.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread InternalDocs/garbage_collector.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread InternalDocs/garbage_collector.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread InternalDocs/garbage_collector.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread InternalDocs/garbage_collector.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread InternalDocs/garbage_collector.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread InternalDocs/garbage_collector.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread InternalDocs/garbage_collector.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@markshannon
Address review comments
a689b38
@markshannon
markshannon requested a review from iritkatriel November 13, 2024 10:30
iritkatriel
iritkatriel reviewed Nov 13, 2024
View reviewed changes
Comment thread InternalDocs/garbage_collector.md Outdated
generations. The main idea behind this concept is the assumption that most
objects have a very short lifespan and can thus be collected soon after their
creation. This has proven to be very close to the reality of many Python
In order to limit the time each garbage collection takes, the GC implementation

@iritkatriel iritkatriel Nov 13, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In order to limit the time each garbage collection takes, the GC implementation
In order to bound the length of each garbage collection pause, the GC implementation

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread InternalDocs/garbage_collector.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread InternalDocs/garbage_collector.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread InternalDocs/garbage_collector.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@markshannon
Further clarifications
f5c6759
iritkatriel
iritkatriel reviewed Nov 13, 2024
View reviewed changes
Comment thread InternalDocs/garbage_collector.md Outdated
Comment on lines +369 to +370
The time taken to scan the young generation can be controlled by controlling the
size of the young, but the size of the old generation cannot be controlled.

@iritkatriel iritkatriel Nov 13, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The time taken to scan the young generation can be controlled by controlling the
size of the young, but the size of the old generation cannot be controlled.
The time taken to scan the young generation can be controlled by controlling its
size, but the size of the old generation cannot be controlled.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread InternalDocs/garbage_collector.md Outdated
Each full scavenge is performed in a series of increments.
For each full scavenge, the combined increments will cover the whole heap.

For each increment, the portion of the heap scanned by a single collection is

@iritkatriel iritkatriel Nov 13, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does "by a single collection" mean here?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@markshannon
A couple more edits
f5b437c
iritkatriel
iritkatriel approved these changes Nov 13, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 13, 2024
@markshannon
markshannon merged commit 3966d8d into python:main Nov 14, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 14, 2024
@markshannon
markshannon deleted the update-gc-internal-docs branch November 18, 2024 14:36
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@markshannon @picnixz
pythonGH-117759: Update GC docs for incremental collection (pythonGH-…
23e1c3d
…126695)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@markshannon @ebonnal
pythonGH-117759: Update GC docs for incremental collection (pythonGH-…
80535aa
…126695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
+1 more reviewer
@danielhollas danielhollas danielhollas left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @iritkatriel @danielhollas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.