GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] gh-95588: Drop the safety claim from `ast.literal_eval` docs. (GH-95919) by miss-islington · Pull Request #126729 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 12, 2024 •
edited by gpshead
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

It was never really safe and this claim conflicts directly with the big warning in the docs about it being able to crash the interpreter.
(cherry picked from commit 8baef8a)

Co-authored-by: Gregory P. Smith [email protected]

  • Issue: Rephrase ast.literal_eval() to remove any security warranty #95588

Fixes #126711

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead @miss-islington
pythongh-95588: Drop the safety claim from ast.literal_eval docs. (p…
d276b5a 
…ythonGH-95919)

It was never really safe and this claim conflicts directly with the big warning in the docs about it being able to crash the interpreter.
(cherry picked from commit 8baef8a)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Nov 12, 2024
gh-95588: Drop the safety claim from ast.literal_eval docs. #95919
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Nov 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 12, 2024
Rephrase ast.literal_eval() to remove any security warranty #95588
Closed
@skirpichev skirpichev mentioned this pull request Nov 12, 2024
ast.literal_eval Segmentation Fault in Python 3.9/3.10 #126711
Closed
@Eclips4

Eclips4 commented Nov 12, 2024

Copy link
Copy Markdown
Member

cc @gpshead @ambv
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev

skirpichev commented Nov 12, 2024

Copy link
Copy Markdown
Member

See #126711
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead assigned ambv Nov 12, 2024
@gpshead gpshead added docs Documentation in the Doc dir type-security A security issue labels Nov 12, 2024
@ambv
ambv merged commit 08830c7 into python:3.9 Dec 3, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Dec 3, 2024
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull request Apr 9, 2025
@miss-islington @gpshead @mgorny
[3.9] pythongh-95588: Drop the safety claim from ast.literal_eval d…
953a502 
…ocs. (pythonGH-95919) (pythonGH-126729)

It was never really safe and this claim conflicts directly with the big warning in the docs about it being able to crash the interpreter.
(cherry picked from commit 8baef8a)

Co-authored-by: Gregory P. Smith <[email protected]>
@miss-islington
miss-islington deleted the backport-8baef8a-3.9 branch January 2, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ambv ambv

Labels

docs Documentation in the Doc dir type-security A security issue

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @Eclips4 @skirpichev @ambv @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.