GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126742: allow to use non-UTF8 exception messages by picnixz · Pull Request #126746 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Nov 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Allow to set non-UTF8 exception messages #126742

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
allow to use translated exception messages
24eb521
@bedevere-app bedevere-app Bot added the awaiting review label Nov 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 12, 2024
Allow to set non-UTF8 exception messages #126742
Closed
@picnixz picnixz added the skip news label Nov 12, 2024
@picnixz picnixz changed the title gh-126742: allow to use translated exception messages gh-126742: allow to use non-UTF8 exception messages Nov 12, 2024
@picnixz
picnixz requested review from ZeroIntensity and encukou November 12, 2024 14:25
ZeroIntensity
ZeroIntensity reviewed Nov 12, 2024
View reviewed changes
Comment thread Python/errors.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/errors.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity

ZeroIntensity commented Nov 12, 2024

Copy link
Copy Markdown
Member

Technically, since this is a bugfix, let's wait until #126555 has landed before we merge this, and then address all the uses of dlerror() in this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity added DO-NOT-MERGE needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Nov 12, 2024
@picnixz

picnixz commented Nov 12, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

then address all the uses of dlerror() in this PR.

I actually thought of doing it two PRs. Technically, this specific PR can be merged without waiting for the other and then you can use this interface in the other (rather the other way around).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity

ZeroIntensity commented Nov 12, 2024

Copy link
Copy Markdown
Member

Eh, I would rather not. Let's not overwhelm someone with thread states and the private API on their first PR :)
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
Use 'surrogateescape' handler instead of 'strict' handler.
4c0f85b
@ZeroIntensity ZeroIntensity removed needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes DO-NOT-MERGE labels Nov 13, 2024
@ZeroIntensity

ZeroIntensity commented Nov 13, 2024

Copy link
Copy Markdown
Member

I've removed backport labels, per what Petr said in the issue. I think he's right--let's just focus on main with this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Nov 15, 2024

Copy link
Copy Markdown
Member

Hmm, just had an idea: if we add a “char* in locale encoding” format to PyUnicode_FromFormat, it'll be possible to use it with PyErr_Format -- but also for non-error messages.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity

ZeroIntensity commented Nov 15, 2024

Copy link
Copy Markdown
Member

I like that idea! But we're exposing this as a public API--how often might users need this? (I've never needed to mess with locale in any of my C API usage, but to be fair I'm typically not calling APIs that return strings.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Nov 15, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Hmm, just had an idea: if we add a “char* in locale encoding” format to

I'm not very fond of adding a case to additionally check when there's not a lot of use cases (unless proven otherwise). It shouldn't affect performances much (but this needs verification) but this would complicate an already complicate function I think (and people need to remember this new format as well).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity

ZeroIntensity commented Nov 15, 2024

Copy link
Copy Markdown
Member

No no, I don't think he meant a variation of PyUnicode_FromFormat that takes a locale, he meant a format value %whatever that automatically calls PyUnicode_DecodeLocale or something like that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Nov 15, 2024

Copy link
Copy Markdown
Member Author

No no, I don't think he meant a variation of PyUnicode_FromFormat that takes a locale, he meant a format value %whatever that automatically calls PyUnicode_DecodeLocale or something like that.

And I understood. I don't think a new code should be added unless there is a real need.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity

ZeroIntensity commented Nov 15, 2024

Copy link
Copy Markdown
Member

And I understood.

Ah! I couldn't tell, sorry.

A code search for PyUnicode_DecodeLocale is showing not too much real world usage--maybe that's a bad thing? Depending on how common it is for a non-UTF8 locale to break things, maybe it would be a good idea to add a format character just so people start handling it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Nov 19, 2024

Copy link
Copy Markdown
Member

It could also show that we're mainly handling errors from the OS at one point -- the OSError constructor. That would be a good thing :)

Anyway, for this PR: @picnixz, do you want to add calls to the new helper(s)?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity

ZeroIntensity commented Nov 19, 2024

Copy link
Copy Markdown
Member

FWIW, Bénédikt is on vacation right now. I don't think he'll be able to implement anything until next week.
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Nov 19, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the purpose of these internal functions since they are now used. This PR only adds dead code. I would prefer to see how these functions are used.

If only dlerror() uses it, why not using code using dlerror()?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Include/internal/pycore_pyerrors.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou marked this pull request as draft November 20, 2024 09:46
@bedevere-app bedevere-app Bot removed the awaiting review label Nov 20, 2024
@miss-islington-app

miss-islington-app Bot commented Dec 17, 2024

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Dec 17, 2024

Copy link
Copy Markdown

Sorry, @picnixz and @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7303f06846b69016a075bca7ad7c6055f29ad024 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned encukou Dec 17, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 17, 2024
@picnixz @vstinner @miss-islington
pythongh-126742: Add _PyErr_SetLocaleString, use it for gdbm & dlerro…
8aa31bb 
…r messages (pythonGH-126746)

- Add a helper to set an error from locale-encoded `char*`
- Use the helper for gdbm & dlerror messages
(cherry picked from commit 7303f06)

Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented Dec 17, 2024

Copy link
Copy Markdown

GH-128023 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Dec 17, 2024
@serhiy-storchaka

serhiy-storchaka commented Dec 17, 2024

Copy link
Copy Markdown
Member

This is a bug fix. It should be backported.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Dec 17, 2024

Copy link
Copy Markdown
Member Author

Ah! I think we should also have a NEWS entry. I'll add one. Sorry for forgetting about it :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Dec 17, 2024

Copy link
Copy Markdown
Member Author

Concerning the failure on 3.12 backport it's because we did not backported the PR on dlerror() usages yet. I've opened a PR for that #127764
serhiy-storchaka reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz deleted the fix/locale-set-object-exception-126742 branch December 17, 2024 11:44
serhiy-storchaka pushed a commit that referenced this pull request Dec 17, 2024
@miss-islington @picnixz @vstinner
[3.13] gh-126742: Add _PyErr_SetLocaleString, use it for gdbm & dlerr…
fe08cdf 
…or messages (GH-126746) (GH-128023)

- Add a helper to set an error from locale-encoded `char*`
- Use the helper for gdbm & dlerror messages
(cherry picked from commit 7303f06)

Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@picnixz picnixz added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Dec 17, 2024
@miss-islington-app

miss-islington-app Bot commented Dec 17, 2024

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Dec 17, 2024

Copy link
Copy Markdown

Sorry, @picnixz and @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7303f06846b69016a075bca7ad7c6055f29ad024 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Dec 17, 2024

Copy link
Copy Markdown
Member Author

Grrr. I thought that the conflicts would be easily solved but apparently not. I'll do the backport manually.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz added a commit to picnixz/cpython that referenced this pull request Dec 17, 2024
@picnixz @vstinner
pythongh-126742: Add _PyErr_SetLocaleString, use it for gdbm & dlerro…
edd033a 
…r messages (pythonGH-126746)

- Add a helper to set an error from locale-encoded `char*`
- Use the helper for gdbm & dlerror messages

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented Dec 17, 2024

Copy link
Copy Markdown

GH-128027 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 17, 2024
serhiy-storchaka pushed a commit that referenced this pull request Dec 17, 2024
@picnixz @vstinner
[3.12] gh-126742: Add _PyErr_SetLocaleString, use it for gdbm & dlerr…
e0b61ff 
…or messages (GH-126746) (GH-128027)

- Add a helper to set an error from locale-encoded `char*`
- Use the helper for gdbm & dlerror messages

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot

bedevere-bot commented Dec 17, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 3.x has failed when building commit 7303f06.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/559/builds/5438) and take a look at the build logs.
  4. Check if the failure is related to this commit (7303f06) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/559/builds/5438

Failed tests:

  • test_ctypes

Failed subtests:

  • test_localized_error_in_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_in_dll
  • test_localized_error_from_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_from_dll
  • test_localized_error_dlsym - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_dlsym

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/test/test_ctypes/test_dlerror.py", line 179, in test_localized_error_dlsym
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/test/test_ctypes/test_dlerror.py", line 144, in test_localized_error_from_dll
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/test/test_ctypes/test_dlerror.py", line 153, in test_localized_error_in_dll
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Dec 17, 2024

Copy link
Copy Markdown
Member Author

Ok, so I didn't expect that on some archs, the error message would be different...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Dec 17, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 LTO 3.x has failed when building commit 7303f06.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/361/builds/5642) and take a look at the build logs.
  4. Check if the failure is related to this commit (7303f06) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/361/builds/5642

Failed tests:

  • test_ctypes

Failed subtests:

  • test_localized_error_in_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_in_dll
  • test_localized_error_from_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_from_dll
  • test_localized_error_dlsym - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_dlsym

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/test/test_ctypes/test_dlerror.py", line 179, in test_localized_error_dlsym
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/test/test_ctypes/test_dlerror.py", line 153, in test_localized_error_in_dll
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/test/test_ctypes/test_dlerror.py", line 144, in test_localized_error_from_dll
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Dec 17, 2024

Copy link
Copy Markdown
Member

Tests are failing on PPC64LE RHEL8 LTO 3.x:

AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Dec 17, 2024

Copy link
Copy Markdown
Member Author

I've opened #128034 for this but Serhiy suggested removing the filename check as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Dec 17, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 3.13 has failed when building commit fe08cdf.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1430/builds/360) and take a look at the build logs.
  4. Check if the failure is related to this commit (fe08cdf) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1430/builds/360

Failed tests:

  • test_ctypes

Failed subtests:

  • test_localized_error_in_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_in_dll
  • test_localized_error_from_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_from_dll
  • test_localized_error_dlsym - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_dlsym

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le/build/Lib/test/test_ctypes/test_dlerror.py", line 153, in test_localized_error_in_dll
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le/build/Lib/test/test_ctypes/test_dlerror.py", line 144, in test_localized_error_from_dll
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le/build/Lib/test/test_ctypes/test_dlerror.py", line 179, in test_localized_error_dlsym
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Dec 17, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 LTO + PGO 3.13 has failed when building commit fe08cdf.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1444/builds/374) and take a look at the build logs.
  4. Check if the failure is related to this commit (fe08cdf) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1444/builds/374

Failed tests:

  • test_ctypes

Failed subtests:

  • test_localized_error_in_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_in_dll
  • test_localized_error_from_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_from_dll
  • test_localized_error_dlsym - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_dlsym

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/test/test_ctypes/test_dlerror.py", line 153, in test_localized_error_in_dll
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/test/test_ctypes/test_dlerror.py", line 179, in test_localized_error_dlsym
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/test/test_ctypes/test_dlerror.py", line 144, in test_localized_error_from_dll
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Dec 17, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 LTO 3.13 has failed when building commit fe08cdf.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1412/builds/375) and take a look at the build logs.
  4. Check if the failure is related to this commit (fe08cdf) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1412/builds/375

Failed tests:

  • test_ctypes

Failed subtests:

  • test_localized_error_in_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_in_dll
  • test_localized_error_from_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_from_dll
  • test_localized_error_dlsym - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_dlsym

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto/build/Lib/test/test_ctypes/test_dlerror.py", line 153, in test_localized_error_in_dll
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto/build/Lib/test/test_ctypes/test_dlerror.py", line 144, in test_localized_error_from_dll
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto/build/Lib/test/test_ctypes/test_dlerror.py", line 179, in test_localized_error_dlsym
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Dec 17, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 Refleaks 3.13 has failed when building commit fe08cdf.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1407/builds/317) and take a look at the build logs.
  4. Check if the failure is related to this commit (fe08cdf) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1407/builds/317

Failed tests:

  • test_ctypes

Failed subtests:

  • test_localized_error_in_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_in_dll
  • test_localized_error_from_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_from_dll
  • test_localized_error_dlsym - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_dlsym

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.refleak/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.refleak/build/Lib/test/test_ctypes/test_dlerror.py", line 153, in test_localized_error_in_dll
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.refleak/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.refleak/build/Lib/test/test_ctypes/test_dlerror.py", line 144, in test_localized_error_from_dll
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.refleak/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.refleak/build/Lib/test/test_ctypes/test_dlerror.py", line 179, in test_localized_error_dlsym
    self.assertIn(self.libc_filename, str(cm.exception))
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@picnixz @vstinner @srinivasreddy
pythongh-126742: Add _PyErr_SetLocaleString, use it for gdbm & dlerro…
f0e854d 
…r messages (pythonGH-126746)

- Add a helper to set an error from locale-encoded `char*`
- Use the helper for gdbm & dlerror messages

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@vstinner vstinner vstinner approved these changes
@encukou encukou encukou approved these changes
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@encukou encukou

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@picnixz @ZeroIntensity @encukou @vstinner @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.