GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "GH-126491: GC: Mark objects reachable from roots before doing cycle collection (GH-126502)" by hugovk · Pull Request #126983 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Nov 18, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit b0fcc2c.

  • Issue: Mark all objects reachable from roots as live before doing main cyclic GC pass #126491

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Revert "pythonGH-126491: GC: Mark objects reachable from roots before…
2ac5c48 
… doing cycle collection (pythonGH-126502)"

This reverts commit b0fcc2c.
@bedevere-app bedevere-app Bot mentioned this pull request Nov 18, 2024
Mark all objects reachable from roots as live before doing main cyclic GC pass #126491
Open
@hugovk hugovk added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 18, 2024
@bedevere-bot

bedevere-bot commented Nov 18, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 2ac5c48 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 18, 2024
@hugovk hugovk mentioned this pull request Nov 18, 2024
GH-126491: GC: Mark objects reachable from roots before doing cycle collection #126502
Merged
@hugovk
hugovk marked this pull request as ready for review November 19, 2024 06:57
@hugovk
hugovk requested review from ericsnowcurrently, markshannon and methane as code owners November 19, 2024 06:57
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 19, 2024
@hugovk
hugovk merged commit 899fdb2 into python:main Nov 19, 2024
@hugovk
hugovk deleted the 3.14-revert-b0fcc2c branch November 19, 2024 09:25
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 19, 2024
@hugovk

hugovk commented Nov 19, 2024

Copy link
Copy Markdown
Member Author

Merged because it's 3.14.0a2 release day and there's two failing tier-1 buildbots, two failing tier-2, and six failing tier-3. Tier-1 need fixing/reverting immediately and tier-2 within 24 hours. The first failing tier-1 was 14 hours ago and tier-2 was 18 hours ago.

  • https://buildbot.python.org/#/release_status
  • https://peps.python.org/pep-0011/
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood mentioned this pull request Nov 19, 2024
Incremental GC causes a significant slowdown for Sphinx #124567
Closed
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@hugovk @ebonnal
Revert "pythonGH-126491: GC: Mark objects reachable from roots before…
53b8263 
… doing cycle collection (pythonGH-126502)" (python#126983)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@methane methane Awaiting requested review from methane methane is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.