GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112136: Remove unused #include "pycore_lock.h" by vstinner · Pull Request #127093 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

pycore_modsupport.h no longer needs pycore_lock.h.

  • Issue: [C API] Removed private _PyArg_Parser API has no replacement in Python 3.13 #112136

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-112136: Remove unused #include "pycore_lock.h"
e61c5b0 
pycore_modsupport.h no longer needs pycore_lock.h.
@vstinner vstinner added the skip news label Nov 21, 2024
@vstinner
vstinner requested a review from ericsnowcurrently as a code owner November 21, 2024 09:47
@bedevere-app bedevere-app Bot mentioned this pull request Nov 21, 2024
[C API] Removed private _PyArg_Parser API has no replacement in Python 3.13 #112136
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 21, 2024
@vstinner vstinner mentioned this pull request Nov 21, 2024
gh-126316: Make grp.getgrall() thread-safe: add a mutex #127055
Merged
cmaloney
cmaloney approved these changes Nov 21, 2024
View reviewed changes
@vstinner
vstinner merged commit 0c5556f into python:main Nov 21, 2024
@vstinner
vstinner deleted the pycore_modsupport branch November 21, 2024 12:50
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 21, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@vstinner @ebonnal
pythongh-112136: Remove unused #include "pycore_lock.h" (python#127093)
fffaee3 
pycore_modsupport.h no longer needs pycore_lock.h.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmaloney cmaloney cmaloney approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @cmaloney
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.