GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK by vstinner · Pull Request #127593 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Dec 4, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Expose PIDFD_NONBLOCK as os.PIDFD_NONBLOCK #93312

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK
8829071
@vstinner vstinner added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Dec 4, 2024
@vstinner
vstinner requested review from corona10 and erlend-aasland as code owners December 4, 2024 10:02
@bedevere-app bedevere-app Bot mentioned this pull request Dec 4, 2024
Expose PIDFD_NONBLOCK as os.PIDFD_NONBLOCK #93312
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 4, 2024
@vstinner

vstinner commented Dec 4, 2024

Copy link
Copy Markdown
Member Author

cc @kumaraditya303
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Dec 5, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 5, 2024
@vstinner
vstinner merged commit fcbe6ec into python:main Dec 5, 2024
@vstinner
vstinner deleted the pidfd branch December 5, 2024 09:39
@miss-islington-app

miss-islington-app Bot commented Dec 5, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 5, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2024
@vstinner @miss-islington
pythongh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (pythonGH…
25ff4df 
…-127593)

(cherry picked from commit fcbe6ec)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington-app

miss-islington-app Bot commented Dec 5, 2024

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fcbe6ecdb6ed4dd93b2ee144f89a73af755e2634 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned vstinner Dec 5, 2024
@bedevere-app

bedevere-app Bot commented Dec 5, 2024

Copy link
Copy Markdown

GH-127630 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Dec 5, 2024
@bedevere-app

bedevere-app Bot commented Dec 5, 2024

Copy link
Copy Markdown

GH-127631 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 5, 2024
vstinner added a commit that referenced this pull request Dec 5, 2024
@vstinner
[3.12] gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (#127593) (
288d6d0 
#127631)

gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (#127593)

(cherry picked from commit fcbe6ec)
vstinner added a commit that referenced this pull request Dec 5, 2024
@miss-islington @vstinner
[3.13] gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (GH-127593…
3e11b5c 
…) (#127630)

gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (GH-127593)
(cherry picked from commit fcbe6ec)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot

bedevere-bot commented Dec 5, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 Refleaks 3.12 has failed when building commit 288d6d0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1187/builds/754) and take a look at the build logs.
  4. Check if the failure is related to this commit (288d6d0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1187/builds/754

Failed tests:

  • test_site
  • test_audit

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 12, done.        
remote: Counting objects:   9% (1/11)        
remote: Counting objects:  18% (2/11)        
remote: Counting objects:  27% (3/11)        
remote: Counting objects:  36% (4/11)        
remote: Counting objects:  45% (5/11)        
remote: Counting objects:  54% (6/11)        
remote: Counting objects:  63% (7/11)        
remote: Counting objects:  72% (8/11)        
remote: Counting objects:  81% (9/11)        
remote: Counting objects:  90% (10/11)        
remote: Counting objects: 100% (11/11)        
remote: Counting objects: 100% (11/11), done.        
remote: Compressing objects:   9% (1/11)        
remote: Compressing objects:  18% (2/11)        
remote: Compressing objects:  27% (3/11)        
remote: Compressing objects:  36% (4/11)        
remote: Compressing objects:  45% (5/11)        
remote: Compressing objects:  54% (6/11)        
remote: Compressing objects:  63% (7/11)        
remote: Compressing objects:  72% (8/11)        
remote: Compressing objects:  81% (9/11)        
remote: Compressing objects:  90% (10/11)        
remote: Compressing objects: 100% (11/11)        
remote: Compressing objects: 100% (11/11), done.        
remote: Total 12 (delta 1), reused 5 (delta 0), pack-reused 1 (from 1)        
From https://github.com/python/cpython
 * branch                    3.12       -> FETCH_HEAD
Note: switching to '288d6d04aedd62a83a19023f83fc7d1742bfba84'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 288d6d04aed [3.12] gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (#127593) (#127631)
Switched to and reset branch '3.12'

make: *** [Makefile:2021: buildbottest] Error 2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Dec 5, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL9 Refleaks 3.12 has failed when building commit 288d6d0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1569/builds/319) and take a look at the build logs.
  4. Check if the failure is related to this commit (288d6d0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1569/builds/319

Failed tests:

  • test_site
  • test_audit

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 12, done.        
remote: Counting objects:   9% (1/11)        
remote: Counting objects:  18% (2/11)        
remote: Counting objects:  27% (3/11)        
remote: Counting objects:  36% (4/11)        
remote: Counting objects:  45% (5/11)        
remote: Counting objects:  54% (6/11)        
remote: Counting objects:  63% (7/11)        
remote: Counting objects:  72% (8/11)        
remote: Counting objects:  81% (9/11)        
remote: Counting objects:  90% (10/11)        
remote: Counting objects: 100% (11/11)        
remote: Counting objects: 100% (11/11), done.        
remote: Compressing objects:   9% (1/11)        
remote: Compressing objects:  18% (2/11)        
remote: Compressing objects:  27% (3/11)        
remote: Compressing objects:  36% (4/11)        
remote: Compressing objects:  45% (5/11)        
remote: Compressing objects:  54% (6/11)        
remote: Compressing objects:  63% (7/11)        
remote: Compressing objects:  72% (8/11)        
remote: Compressing objects:  81% (9/11)        
remote: Compressing objects:  90% (10/11)        
remote: Compressing objects: 100% (11/11)        
remote: Compressing objects: 100% (11/11), done.        
remote: Total 12 (delta 1), reused 5 (delta 0), pack-reused 1 (from 1)        
From https://github.com/python/cpython
 * branch                    3.12       -> FETCH_HEAD
Note: switching to '288d6d04aedd62a83a19023f83fc7d1742bfba84'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 288d6d04aed [3.12] gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (#127593) (#127631)
Switched to and reset branch '3.12'

make: *** [Makefile:2021: buildbottest] Error 2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 mentioned this pull request Dec 6, 2024
os.PIDFD_NONBLOCK is missing, yet according to documentation it should be present #127583
Closed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@vstinner @srinivasreddy
pythongh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (python#1…
f2e4894 
…27593)
@KaiErikNiermann KaiErikNiermann mentioned this pull request Oct 9, 2026
Various missing constants (and some functions) astral-sh/python-build-standalone#1325
Open
charrus added a commit to charrus/MythTV-Web that referenced this pull request Oct 11, 2026
@charrus
Pin python to be the same as github workflows, and bump uv to fix pyt…
6b824c6 
…hon/cpython#127593
@charrus charrus mentioned this pull request Oct 11, 2026
Make MythTV Web easier to contribute to with uv, and fix review findings mspieth/MythTV-Web#1
Merged
mspieth pushed a commit to mspieth/MythTV-Web that referenced this pull request Oct 18, 2026
@charrus @mspieth
Pin python to be the same as github workflows, and bump uv to fix pyt…
cb8552b 
…hon/cpython#127593
charrus added a commit to charrus/MythTV-Web that referenced this pull request Oct 26, 2026
@charrus
Pin python to be the same as github workflows, and bump uv to fix pyt…
042487d 
…hon/cpython#127593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.