GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] GH-117195: Avoid assertion error in `object.__sizeof__` (GH-117220) by miss-islington · Pull Request #127605 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Dec 4, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 406ffb5)

Co-authored-by: Mark Shannon [email protected]

  • Issue: object.__sizeof__(1) have different output between 3.9.10 and 3.12.2 #117195

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon @miss-islington
pythonGH-117195: Avoid assertion error in object.__sizeof__ (python…
1ebe0e3 
…GH-117220)

(cherry picked from commit 406ffb5)

Co-authored-by: Mark Shannon <[email protected]>
@miss-islington
miss-islington requested a review from markshannon as a code owner December 4, 2024 14:54
This was referenced Dec 4, 2024
object.__sizeof__(1) have different output between 3.9.10 and 3.12.2 #117195
Closed
GH-117195: Avoid assertion error in object.__sizeof__ #117220
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Dec 4, 2024
@vstinner vstinner mentioned this pull request Dec 4, 2024
Abort from GenericAlias.__sizeof__: ob->ob_type != &PyLong_Type #127603
Closed
vstinner
vstinner approved these changes Dec 4, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Python 3.12 also needs this fix: #127603.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 4, 2024
@vstinner

vstinner commented Dec 4, 2024

Copy link
Copy Markdown
Member

cc @markshannon @iritkatriel @JelleZijlstra
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 0964f9f into python:3.12 Dec 11, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 11, 2024
@miss-islington
miss-islington deleted the backport-406ffb5-3.12 branch January 2, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @vstinner @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.