GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-117195: Avoid assertion error in `object.__sizeof__` by markshannon · Pull Request #117220 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Mar 25, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: object.__sizeof__(1) have different output between 3.9.10 and 3.12.2 #117195

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Avoid assertion error in object.__sizeof__
3423388
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 25, 2024
object.__sizeof__(1) have different output between 3.9.10 and 3.12.2 #117195
Closed
markshannon added 2 commits March 25, 2024 15:48
@markshannon
Add test
7374ca0
@markshannon
Fix mangled name
4078e91
Eclips4
Eclips4 reviewed Mar 25, 2024
View reviewed changes
Comment thread Lib/test/test_long.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
Fix typo
12f7738
@markshannon markshannon added the needs backport to 3.13 only security fixes label May 21, 2024
iritkatriel
iritkatriel approved these changes May 21, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 21, 2024
@markshannon
Merge branch 'main' into object_sizeof_int
6078da5
@markshannon
markshannon merged commit 406ffb5 into python:main May 23, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 23, 2024
@miss-islington-app

miss-islington-app Bot commented May 23, 2024

Copy link
Copy Markdown

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2024
@markshannon @miss-islington
pythonGH-117195: Avoid assertion error in object.__sizeof__ (python…
465e366 
…GH-117220)

(cherry picked from commit 406ffb5)

Co-authored-by: Mark Shannon <[email protected]>
@bedevere-app

bedevere-app Bot commented May 23, 2024

Copy link
Copy Markdown

GH-119456 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 23, 2024
markshannon pushed a commit that referenced this pull request May 23, 2024
@miss-islington
[3.13] GH-117195: Avoid assertion error in object.__sizeof__ (GH-11…
251ef2e 
…7220) (GH-119456)
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@markshannon @estyxx
pythonGH-117195: Avoid assertion error in object.__sizeof__ (python…
512e694 
…GH-117220)
@markshannon
markshannon deleted the object_sizeof_int branch August 6, 2024 10:19
@vstinner vstinner added the needs backport to 3.12 only security fixes label Dec 4, 2024
@miss-islington-app

miss-islington-app Bot commented Dec 4, 2024

Copy link
Copy Markdown

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 4, 2024
@markshannon @miss-islington
pythonGH-117195: Avoid assertion error in object.__sizeof__ (python…
1ebe0e3 
…GH-117220)

(cherry picked from commit 406ffb5)

Co-authored-by: Mark Shannon <[email protected]>
@bedevere-app

bedevere-app Bot commented Dec 4, 2024

Copy link
Copy Markdown

GH-127605 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 4, 2024
@vstinner

vstinner commented Dec 4, 2024

Copy link
Copy Markdown
Member

Python 3.12 is also affected by the issue: #127603.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner pushed a commit that referenced this pull request Dec 11, 2024
@miss-islington @markshannon
[3.12] GH-117195: Avoid assertion error in object.__sizeof__ (GH-11…
0964f9f 
…7220) (#127605)

GH-117195: Avoid assertion error in `object.__sizeof__` (GH-117220)
(cherry picked from commit 406ffb5)

Co-authored-by: Mark Shannon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 left review comments
@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markshannon @vstinner @iritkatriel @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.