GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119182: Complete PyUnicodeWriter documentation by vstinner · Pull Request #127607 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Dec 4, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: [C API] Add an efficient public PyUnicodeWriter API #119182

📚 Documentation preview 📚: https://cpython-previews--127607.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-119182: Complete PyUnicodeWriter documentation
9487866
@vstinner vstinner added the skip news label Dec 4, 2024
@bedevere-app bedevere-app Bot added the docs Documentation in the Doc dir label Dec 4, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 4, 2024
[C API] Add an efficient public PyUnicodeWriter API #119182
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 4, 2024
@vstinner

vstinner commented Dec 4, 2024

Copy link
Copy Markdown
Member Author

cc @pitrou @skirpichev
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland
StanFromIreland approved these changes Dec 4, 2024
View reviewed changes
@skirpichev
skirpichev self-requested a review December 5, 2024 04:41
skirpichev
skirpichev approved these changes Dec 5, 2024
View reviewed changes

@skirpichev skirpichev left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

But, perhaps, you could move sentence "The instance must be destroyed by ... or ..." to the PyUnicodeWriter_Create() docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kumaraditya303
kumaraditya303 approved these changes Dec 5, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 5, 2024
@vstinner
vstinner merged commit 1ef6e8c into python:main Dec 5, 2024
@vstinner
vstinner deleted the writer_doc branch December 5, 2024 09:37
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 5, 2024
@vstinner

vstinner commented Dec 5, 2024

Copy link
Copy Markdown
Member Author

Merged, thanks for reviews.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@vstinner @srinivasreddy
pythongh-119182: Complete PyUnicodeWriter documentation (python#127607)
655ae54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichev skirpichev skirpichev approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @skirpichev @kumaraditya303 @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.