GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-127691: add type checks when using `PyUnicodeError` objects by picnixz · Pull Request #127694 · python/cpython

Conversation

picnixz commented Dec 6, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

I think there will be CI failures so I'll fix them when the CI completes.

Issue: Check for type consistency for PyUnicodeError API #127691

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

picnixz added 2 commits

December 6, 2024 15:49


          add type checks when using PyUnicodeError objects

bd07ea4


          reduce un-necessary casts

21bcef2

bedevere-app Bot mentioned this pull request

Dec 6, 2024

Check for type consistency for PyUnicodeError API #127691

Closed

picnixz added 5 commits

December 6, 2024 16:42


          fix check

17d2665


          fix tests

bac5031


          blurb

37655a2


          fix typo

af7e7bb


          fix refs

a8bfd70

picnixz marked this pull request as ready for review

December 6, 2024 16:07

picnixz requested a review from iritkatriel as a code owner

December 6, 2024 16:07

bedevere-app Bot added the awaiting review label

Dec 6, 2024

picnixz requested a review from encukou

December 6, 2024 16:22

ZeroIntensity reviewed

Dec 6, 2024

View reviewed changes

Comment thread

Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

ZeroIntensity commented Dec 7, 2024

Copy link

Copy Markdown

Member

Will do a thorough review after I finish reviewing a few other things :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ZeroIntensity reviewed

Dec 7, 2024

View reviewed changes

Comment thread

Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update CHANGELOG

0ec814e

picnixz commented

Dec 7, 2024

View reviewed changes

Comment thread

Misc/NEWS.d/next/C_API/2024-12-06-16-53-34.gh-issue-127691.k_Jitp.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Apply suggestions from code review

7c7d20c

picnixz commented

Dec 7, 2024

View reviewed changes

Comment thread

Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update Objects/exceptions.c

49a32cf

picnixz commented

Dec 7, 2024

View reviewed changes

Comment thread

Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update Objects/exceptions.c

a5ee3d0

picnixz commented

Dec 7, 2024

View reviewed changes

Comment thread

Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/C_API/2024-12-06-16-53-34.gh-issue-127691.k_Jitp.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Fix English

7fe6e67

picnixz commented

Dec 7, 2024

View reviewed changes

Comment thread

Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/C_API/2024-12-06-16-53-34.gh-issue-127691.k_Jitp.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Improve wording

970720a

This was referenced Dec 10, 2024

Refactor PyUnicodeError internal C helpers #127787

Closed

gh-127787: refactor helpers for PyUnicodeErrorObject internal interface #127789

Merged

encukou merged commit 8bc1818 into python:main

Dec 13, 2024

bedevere-app Bot removed the awaiting review label

Dec 13, 2024

encukou commented Dec 13, 2024

Copy link

Copy Markdown

Member

Thank you!

picnixz reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

picnixz deleted the feat/codecs/check-types-127691 branch

December 13, 2024 16:21

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request

Jan 8, 2025


          pythongh-127691: add type checks when using PyUnicodeError objects (p…

a7aa09b

…ythonGH-127694)

Reviewers

ZeroIntensity

ZeroIntensity left review comments

iritkatriel

Awaiting requested review from iritkatriel

iritkatriel is a code owner

encukou

Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

picnixz commented Dec 6, 2024 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ZeroIntensity commented Dec 7, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

encukou commented Dec 13, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

picnixz commented Dec 6, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.