GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118915: C API: Document frame locals proxies. by ZeroIntensity · Pull Request #127720 · python/cpython

Conversation

@ZeroIntensity

@ZeroIntensity ZeroIntensity commented Dec 7, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Undocumented 3.13 C API #118915

📚 Documentation preview 📚: https://cpython-previews--127720.org.readthedocs.build/en/127720/c-api/frame.html#frame-locals-proxies

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZeroIntensity
Docs: C API: Document frame locals proxies.
ef168c1
@ZeroIntensity ZeroIntensity added docs Documentation in the Doc dir skip news topic-C-API needs backport to 3.13 only security fixes labels Dec 7, 2024
@ZeroIntensity
ZeroIntensity requested review from gaogaotiantian and markshannon December 7, 2024 15:14
@bedevere-app bedevere-app Bot added the awaiting review label Dec 7, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 7, 2024
Undocumented 3.13 C API #118915
Open
61 of 78 tasks
rruuaanng
rruuaanng reviewed Dec 7, 2024
View reviewed changes
Comment thread Doc/c-api/frame.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/c-api/frame.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
ZeroIntensity added 2 commits December 7, 2024 11:14
@ZeroIntensity
Clarify 3.13
61662c0
@ZeroIntensity
Minor change to wording.
86f7cdd
@gaogaotiantian

gaogaotiantian commented Dec 8, 2024

Copy link
Copy Markdown
Member

Overall I think it's okay, but I'm not the expert in docs. @ncoghlan would fit better in this role. Also maybe someone who's familiar with the docs like @AlexWaygood.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood self-requested a review December 8, 2024 20:09
StanFromIreland
StanFromIreland approved these changes Dec 9, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Dec 9, 2024
AlexWaygood
AlexWaygood reviewed Dec 9, 2024
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/c-api/frame.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity @AlexWaygood
Update frame.rst
8ec995f 
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
AlexWaygood approved these changes Dec 9, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 9, 2024
vstinner
vstinner reviewed Dec 11, 2024
View reviewed changes
Comment thread Doc/c-api/frame.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity
Remove redundant version added directive
4fca539
vstinner
vstinner approved these changes Dec 11, 2024
View reviewed changes
@vstinner
vstinner merged commit dd9da73 into python:main Dec 11, 2024
@miss-islington-app

miss-islington-app Bot commented Dec 11, 2024

Copy link
Copy Markdown

Thanks @ZeroIntensity for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 11, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2024
@ZeroIntensity @AlexWaygood @miss-islington
pythongh-118915: C API: Document frame locals proxies. (pythonGH-127720)
f86cf73 
(cherry picked from commit dd9da73)

Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@bedevere-app

bedevere-app Bot commented Dec 11, 2024

Copy link
Copy Markdown

GH-127831 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Dec 11, 2024
@vstinner

vstinner commented Dec 11, 2024

Copy link
Copy Markdown
Member

Merged, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner pushed a commit that referenced this pull request Dec 11, 2024
@miss-islington @ZeroIntensity @AlexWaygood
[3.13] gh-118915: C API: Document frame locals proxies. (GH-127720) (#…
8b24d04 
…127831)

gh-118915: C API: Document frame locals proxies. (GH-127720)
(cherry picked from commit dd9da73)

Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@ZeroIntensity
ZeroIntensity deleted the document-framelocalsproxy branch December 11, 2024 16:49
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@ZeroIntensity @AlexWaygood @srinivasreddy
pythongh-118915: C API: Document frame locals proxies. (python#127720)
606869b 
Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments
@vstinner vstinner vstinner approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes
@markshannon markshannon Awaiting requested review from markshannon
@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian
+1 more reviewer
@rruuaanng rruuaanng rruuaanng left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-C-API

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@ZeroIntensity @gaogaotiantian @vstinner @picnixz @AlexWaygood @StanFromIreland @rruuaanng
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.