GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127637: add tests for `dis` command-line interface by picnixz · Pull Request #127759 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Dec 9, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We can decide to backport it or not.

  • Issue: Add tests for dis command-line interface #127637

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 2 commits December 9, 2024 12:29
@picnixz
add tests for dis command-line interface
bd6af2c
@picnixz
blurb
a240b81
@picnixz
picnixz requested a review from iritkatriel December 9, 2024 11:36
@bedevere-app bedevere-app Bot added the awaiting review label Dec 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 9, 2024
Add tests for dis command-line interface #127637
Closed
iritkatriel
iritkatriel reviewed Dec 9, 2024
View reviewed changes
Comment thread Lib/test/test_dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel reviewed Dec 9, 2024
View reviewed changes
Comment thread Lib/test/test_dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
address Irit's review
d277814
@picnixz
picnixz requested a review from iritkatriel December 9, 2024 15:03
iritkatriel
iritkatriel reviewed Dec 9, 2024
View reviewed changes
Comment thread Lib/test/test_dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel reviewed Dec 9, 2024
View reviewed changes
Comment thread Lib/test/test_dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
address Irit's review (round 2)
c2a0b43
iritkatriel
iritkatriel reviewed Dec 9, 2024
View reviewed changes
Comment thread Lib/test/test_dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
add test for unknown option
ca68f3b
iritkatriel
iritkatriel reviewed Dec 9, 2024
View reviewed changes
Comment thread Lib/test/test_dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented Dec 9, 2024

Copy link
Copy Markdown
Member

We can decide to backport it or not.

We can backport, but I think it would need manual intervention to remove the new option you added last week.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Dec 9, 2024
@picnixz

picnixz commented Dec 9, 2024

Copy link
Copy Markdown
Member Author

We can backport, but I think it would need manual intervention to remove the new option you added last week.

Yes. But I wondered whether you wanted a NEWS entry as well in the backports (I didn't think of it before...)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Dec 9, 2024

Copy link
Copy Markdown
Member Author

Since I would anyway need a manual backport (otherwise, the tests will fail and it will be harder to edit the PR), I'll remove the backports labels and will make them myself afterwards.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz removed needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Dec 9, 2024
@iritkatriel

iritkatriel commented Dec 9, 2024

Copy link
Copy Markdown
Member

We can backport, but I think it would need manual intervention to remove the new option you added last week.

Yes. But I wondered whether you wanted a NEWS entry as well in the backports (I didn't think of it before...)

The new entry doesn't need to change right?

We don't need this in what's new in.. because it's not user facing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel approved these changes Dec 9, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 9, 2024
@iritkatriel
iritkatriel merged commit e85f2f1 into python:main Dec 9, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 9, 2024
@iritkatriel iritkatriel added tests Tests in the Lib/test dir awaiting merge labels Dec 9, 2024
@picnixz
picnixz deleted the test/dis/127637 branch December 9, 2024 18:05
@picnixz

picnixz commented Dec 9, 2024

Copy link
Copy Markdown
Member Author

I'll do the backports tomorrow.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz added a commit to picnixz/cpython that referenced this pull request Dec 10, 2024
@picnixz
pythongh-127637: add tests for dis command-line interface (python#1…
0b929a7 
…27759)
@bedevere-app

bedevere-app Bot commented Dec 10, 2024

Copy link
Copy Markdown

GH-127780 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz added a commit to picnixz/cpython that referenced this pull request Dec 10, 2024
@picnixz
pythongh-127637: add tests for dis command-line interface (python#1…
8d55075 
…27759)
@bedevere-app

bedevere-app Bot commented Dec 10, 2024

Copy link
Copy Markdown

GH-127781 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz added a commit to picnixz/cpython that referenced this pull request Dec 10, 2024
@picnixz
pythongh-127637: add tests for dis command-line interface (python#1…
eb3ad0f 
…27759)
picnixz added a commit to picnixz/cpython that referenced this pull request Dec 10, 2024
@picnixz
pythongh-127637: add tests for dis command-line interface (python#1…
2d880a1 
…27759)
iritkatriel pushed a commit that referenced this pull request Dec 10, 2024
@picnixz
[3.13] gh-127637: add tests for dis command-line interface (#127759) (
8bf5b89 
#127781)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@picnixz @srinivasreddy
pythongh-127637: add tests for dis command-line interface (python#1…
1c803ca 
…27759)
picnixz added a commit that referenced this pull request Jan 18, 2025
@picnixz
[3.12] gh-127637: add tests for dis command-line interface (#127759) (
fbbef60 
#127780)
@donbarbos donbarbos mentioned this pull request Mar 13, 2025
Add tests for command-line interface #131178
Open
7 of 9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.