GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126491: Revert "GH-126491: Lower heap size limit with faster marking (GH-127519)" by encukou · Pull Request #127770 · python/cpython

Conversation

@encukou

@encukou encukou commented Dec 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 023b7d2, which introduced a refleak in test_import.

Per PEP 11 break should be fixed or reverted immediately. I don't immediately see the problem, though. (Perhaps it's just a test issue?)

  • Issue: Mark all objects reachable from roots as live before doing main cyclic GC pass #126491

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
Revert "pythonGH-126491: Lower heap size limit with faster marking (p…
16327ad 
…ythonGH-127519)"

This reverts commit 023b7d2, which introduced
a refleak.
@encukou
encukou requested review from markshannon and methane as code owners December 9, 2024 16:54
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 9, 2024
@encukou encukou changed the title gh-127519: Revert "GH-126491: Lower heap size limit with faster marking (GH-127519)" gh-126491: Revert "GH-126491: Lower heap size limit with faster marking (GH-127519)" Dec 9, 2024
@encukou encukou added the skip news label Dec 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 9, 2024
Mark all objects reachable from roots as live before doing main cyclic GC pass #126491
Open
@encukou encukou mentioned this pull request Dec 9, 2024
GH-126491: Lower heap size limit with faster marking #127519
Merged
@encukou
encukou merged commit 690fe07 into python:main Dec 10, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Dec 10, 2024
@encukou
encukou deleted the revert-023b7d2 branch December 10, 2024 10:54
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@encukou @srinivasreddy
pythongh-126491: Revert "pythonGH-126491: Lower heap size limit with …
13d7d0b 
…faster marking (pythonGH-127519)" (pythonGH-127770)

Revert "pythonGH-126491: Lower heap size limit with faster marking (pythonGH-127519)"

This reverts commit 023b7d2, which introduced
a refleak.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@methane methane Awaiting requested review from methane methane is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.