GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-125174: Don't use `UINT32_MAX` in header file by markshannon · Pull Request #127863 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Dec 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It breaks a buildbot. Maybe UINT32_MAX isn't defined in their C++ header files.

  • Issue: "Immortal" objects aren't immortal and that breaks things. #125174

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@markshannon
Don't use UINT32_MAX in header file
957cf8a
@markshannon markshannon added the skip news label Dec 12, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 12, 2024
@markshannon markshannon changed the title Don't use UINT32_MAX in header file GH-125174: Don't use UINT32_MAX in header file Dec 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 12, 2024
"Immortal" objects aren't immortal and that breaks things. #125174
Closed
@markshannon markshannon mentioned this pull request Dec 12, 2024
GH-125174: Mark objects as statically allocated. #127797
Merged
@markshannon

markshannon commented Dec 12, 2024

Copy link
Copy Markdown
Member Author

!buildbot "AMD64 FreeBSD 3.x"

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Dec 12, 2024

Copy link
Copy Markdown

The regex '"AMD64 FreeBSD 3.x"' did not match any buildbot builder. Is the requested builder in the list of stable builders?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon

markshannon commented Dec 12, 2024

Copy link
Copy Markdown
Member Author

!buildbot "AMD64.FreeBSD.3.x"

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Dec 12, 2024

Copy link
Copy Markdown

The regex '"AMD64.FreeBSD.3.x"' did not match any buildbot builder. Is the requested builder in the list of stable builders?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon

markshannon commented Dec 12, 2024

Copy link
Copy Markdown
Member Author

!buildbot AMD64.FreeBSD

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Dec 12, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 957cf8a 🤖

The command will test the builders whose names match following regular expression: AMD64.FreeBSD

The builders matched are:

  • AMD64 FreeBSD PR
  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD15 PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@colesbury

colesbury commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

In case you were wondering why it's missing, like I was:

The C99 standard suggests that C++ implementations should not define the above limit, constant, or format macros unless the macros __STDC_LIMIT_MACROS, __STDC_CONSTANT_MACROS or __STDC_FORMAT_MACROS (respectively) are defined before including the relevant C header (stdint.h or inttypes.h). This recommendation was not adopted by any C++ standard and was removed in C11. However, some implementations (such as glibc 2.17) try to apply this rule, and it may be necessary to define the __STDC macros; C++ compilers may try to work around this by automatically defining them in some circumstances

https://en.cppreference.com/w/cpp/types/integer

ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon
markshannon requested a review from encukou December 12, 2024 15:56
@encukou
encukou merged commit 9b4bbf4 into python:main Dec 13, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Dec 13, 2024
@encukou

encukou commented Dec 13, 2024

Copy link
Copy Markdown
Member

Thank you for the fix!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@markshannon @srinivasreddy
pythonGH-125174: Don't use UINT32_MAX in header file (pythonGH-127863)
157a9a0
@markshannon
markshannon deleted the no-uint32 branch January 10, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markshannon @bedevere-bot @colesbury @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.