GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127879: Fix data race in `_PyFreeList_Push` by colesbury · Pull Request #127880 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Dec 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Writes to the ob_tid field need to use atomics because it may be concurrently read by a non-locking dictionary, list, or structmember read.

  • Issue: Race in _PyFreeList_Push #127879

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-127879: Fix data race in _PyFreeList_Push
e90a0e1 
Writes to the `ob_tid` field need to use atomics because it may be
concurrently read by a non-locking dictionary, list, or structmember
read.
@colesbury colesbury added skip news topic-free-threading labels Dec 12, 2024
@colesbury
colesbury requested a review from mpage December 12, 2024 17:30
@colesbury
colesbury requested a review from ericsnowcurrently as a code owner December 12, 2024 17:30
@bedevere-app bedevere-app Bot mentioned this pull request Dec 12, 2024
Race in _PyFreeList_Push #127879
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 12, 2024
@colesbury colesbury mentioned this pull request Dec 12, 2024
gh-126868: Add freelist for compact int objects #126865
Merged
@colesbury

colesbury commented Dec 12, 2024

Copy link
Copy Markdown
Contributor Author

I tested this locally on top of #126865 and no longer see a TSan failure when running:

TSAN_OPTIONS="suppressions=$(pwd)/Tools/tsan/suppressions_free_threading.txt" ./python -m test test_free_threading -m test_slots -v
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner
Fidget-Spinner approved these changes Dec 12, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 12, 2024
mpage
mpage approved these changes Dec 12, 2024
View reviewed changes
@colesbury
colesbury merged commit f8dcb82 into python:main Dec 12, 2024
@colesbury
colesbury deleted the gh-127879-freelist branch December 12, 2024 17:59
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 12, 2024
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@colesbury @srinivasreddy
pythongh-127879: Fix data race in _PyFreeList_Push (python#127880)
c0571fc 
Writes to the `ob_tid` field need to use atomics because it may be
concurrently read by a non-locking dictionary, list, or structmember
read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpage mpage mpage approved these changes
@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@colesbury @mpage @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.