GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: fix UBSan failures in `_elementtree.c` by picnixz · Pull Request #127982 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Dec 16, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 5 commits December 16, 2024 12:45
@picnixz
Fix UBSan failures in xml.etree.ElementTree.Element
f3b8625
@picnixz
Fix UBSan failures in _elementtree._element_iterator
26a172c
@picnixz
Fix UBSan failures in xml.etree.ElementTree.TreeBuilder
52fdab1
@picnixz
Fix UBSan failures in xml.etree.ElementTree.XMLParser
9ba4c17
@picnixz
suppress unused return value
19df9ba
@bedevere-app bedevere-app Bot mentioned this pull request Dec 16, 2024
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Dec 16, 2024
@picnixz picnixz added the skip news label Dec 16, 2024
@picnixz
picnixz requested a review from vstinner December 16, 2024 11:54
vstinner
vstinner reviewed Dec 16, 2024
View reviewed changes
Comment thread Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz added 3 commits December 16, 2024 13:18
@picnixz
use 'op' instead of 'PTR' in cast macros
bfe7fdd
@picnixz
reduce diff
d1b2d52
@picnixz
reduce diff
766a448
vstinner
vstinner approved these changes Dec 16, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_elementtree.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 16, 2024
@vstinner
vstinner merged commit 0d8e710 into python:main Dec 16, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 16, 2024
@vstinner

vstinner commented Dec 16, 2024

Copy link
Copy Markdown
Member

Merged, thank you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz deleted the fix/ubsan/etree/111178 branch December 16, 2024 13:40
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@picnixz @srinivasreddy
pythongh-111178: fix UBSan failures in _elementtree.c (python#127982)
bda6a70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.