GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127146: Emscripten Include compiler version in _PYTHON_HOST_PLATFORM by hoodmane · Pull Request #127992 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Dec 16, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

test_sysconfigdata_json is failing. This doesn't entirely fix it but it moves the failure later -- before this change it doesn't even find the sysconfigdata file because of a descrepancy between what uname() returns and what configure.ac sets _PYTHON_HOST_PLATFORM to. After, there are some small differences.

  • Issue: Emscripten: Get test suite passing #127146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
pythongh-127146: Emscripten Include compiler version in _PYTHON_HOST_…
0c33f20 
…PLATFORM

`test_sysconfigdata_json` is failing. This doesn't entirely fix it but it moves
the failure later -- before it doesn't even find the sysconfigdata file because
of a descrepancy between what `uname()` returns and what `configure.ac` sets
`_PYTHON_HOST_PLATFORM` to. After, there are some small differences.
@hoodmane
hoodmane requested a review from freakboy3742 December 16, 2024 15:59
@hoodmane
hoodmane requested review from corona10 and erlend-aasland as code owners December 16, 2024 15:59
@bedevere-app bedevere-app Bot mentioned this pull request Dec 16, 2024
Emscripten: Get test suite passing #127146
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Dec 16, 2024
@hoodmane hoodmane added the skip news label Dec 16, 2024
@hoodmane

hoodmane commented Dec 16, 2024

Copy link
Copy Markdown
Contributor Author

To actually fix the test, we could either skip the check for prefix-related keys or regenerate the sysconfigdata with the cli after the build is completed. The first change would look like:

@@ -651,9 +652,13 @@ def test_sysconfigdata_json(self):
         system_config_vars = get_config_vars()
 
         # Ignore keys in the check
-        for key in ('projectbase', 'srcdir'):
-            json_config_vars.pop(key)
-            system_config_vars.pop(key)
+        ignore_keys = ('projectbase', 'srcdir')
+        if is_emscripten:
+            ignore_keys += ("exec_prefix", "installed_base", "installed_platbase", "prefix", "platbase", "userbase")
+
+        for key in ignore_keys:
+            json_config_vars.pop(key, None)
+            system_config_vars.pop(key, None)
 
         self.assertEqual(system_config_vars, json_config_vars)

@freakboy3742 maybe we could do this for android and ios too?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kleisauke
kleisauke reviewed Dec 16, 2024
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane @kleisauke
Update configure.ac
6c3bdd8 
Co-authored-by: Kleis Auke Wolthuizen <[email protected]>
freakboy3742
freakboy3742 requested changes Dec 17, 2024
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself makes sense; one note inline about formatting, and it looks like CI is failing because autoreconf hasn't been run since your most recent update.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Dec 17, 2024
@bedevere-app

bedevere-app Bot commented Dec 17, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting changes label Dec 17, 2024
@hoodmane
Address review comments and rerun autoconf
609da1a
@hoodmane

hoodmane commented Dec 17, 2024

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels Dec 17, 2024
@bedevere-app

bedevere-app Bot commented Dec 17, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@freakboy3742: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app
bedevere-app Bot requested a review from freakboy3742 December 17, 2024 09:13
freakboy3742
freakboy3742 approved these changes Dec 17, 2024
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those fixes - looks great!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting change review labels Dec 17, 2024
@freakboy3742
freakboy3742 merged commit b92f101 into python:main Dec 17, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 17, 2024
@bedevere-bot

bedevere-bot commented Dec 17, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows Server 2022 NoGIL 3.x has failed when building commit b92f101.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1241/builds/4076) and take a look at the build logs.
  4. Check if the failure is related to this commit (b92f101) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1241/builds/4076

Failed tests:

  • test_venv

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_venv.py", line 615, in test_multiprocessing
    out, err = check_output([self.envpy(real_env_dir=True), '-c',
               ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        'from multiprocessing import Pool; '
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        'pool = Pool(1); '
        ^^^^^^^^^^^^^^^^^^
        'print(pool.apply_async("Python".lower).get(3)); '
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        'pool.terminate()'])
        ^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_venv.py", line 58, in check_output
    raise subprocess.CalledProcessError(
        p.returncode, cmd, out, err)
subprocess.CalledProcessError: Command '['C:\\Users\\Administrator\\AppData\\Local\\Temp\\test_python_sfi65_yv\\tmpjhxztw7a\\Scripts\\python3.14t_d.exe', '-c', 'from multiprocessing import Pool; pool = Pool(1); print(pool.apply_async("Python".lower).get(3)); pool.terminate()']' returned non-zero exit status 1.


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_venv.py", line 615, in test_multiprocessing
    out, err = check_output([self.envpy(real_env_dir=True), '-c',
               ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        'from multiprocessing import Pool; '
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        'pool = Pool(1); '
        ^^^^^^^^^^^^^^^^^^
        'print(pool.apply_async("Python".lower).get(3)); '
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        'pool.terminate()'])
        ^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_venv.py", line 58, in check_output
    raise subprocess.CalledProcessError(
        p.returncode, cmd, out, err)
subprocess.CalledProcessError: Command '['C:\\Users\\Administrator\\AppData\\Local\\Temp\\test_python_juj1et4h\\tmp36bh_36p\\Scripts\\python3.14t_d.exe', '-c', 'from multiprocessing import Pool; pool = Pool(1); print(pool.apply_async("Python".lower).get(3)); pool.terminate()']' returned non-zero exit status 1.


Traceback (most recent call last):
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742

freakboy3742 commented Dec 17, 2024

Copy link
Copy Markdown
Contributor

I can't see why this change would have any impact on Windows being unable to start multiprocessing...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane

hoodmane commented Dec 18, 2024

Copy link
Copy Markdown
Contributor Author

Presumably a flake =)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane
hoodmane deleted the emscripten-host-platform branch January 6, 2025 19:20
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Emscripten Include compiler version in _PYTHON_HOST_…
166fd0c 
…PLATFORM (python#127992)

Modifies _PYTHON_HOST_PLATFORM to include the compiler version under
Emscripten. The Emscripten compiler version is the platform version
compatibility identifier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
+1 more reviewer
@kleisauke kleisauke kleisauke left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hoodmane @bedevere-bot @freakboy3742 @kleisauke
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.