GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115999: Update test_opcache to test with nested method by corona10 · Pull Request #128166 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Dec 22, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Make the specializing interpreter thread-safe in --disable-gil builds #115999

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zeze1004 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@corona10
pythongh-115999: Update test_opcace to test with nested method
91e350a
@corona10 corona10 added skip news topic-free-threading labels Dec 22, 2024
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Dec 22, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 22, 2024
Make the specializing interpreter thread-safe in --disable-gil builds #115999
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 22, 2024
@corona10
corona10 requested a review from mpage December 22, 2024 02:21
@corona10

corona10 commented Dec 22, 2024

Copy link
Copy Markdown
Member Author

Since #128012 is merged, we can enable full tests related to BINARY_SUBSCR_GETITEM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 changed the title gh-115999: Update test_opcace to test with nested method gh-115999: Update test_opcache to test with nested method Dec 22, 2024
mpage
mpage approved these changes Dec 23, 2024
View reviewed changes

@mpage mpage left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 23, 2024
@corona10
corona10 merged commit c5b0c90 into python:main Dec 23, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 23, 2024
@corona10
corona10 deleted the gh-115999-test branch December 23, 2024 17:08
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@corona10 @srinivasreddy
pythongh-115999: Update test_opcache to test with nested method (pyth…
148b9cf 
…ongh-128166)

pythongh-115999: Update test_opcace to test with nested method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpage mpage mpage approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corona10 @mpage
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.