GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127949: add docs for asyncio policy deprecation by kumaraditya303 · Pull Request #128269 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Dec 26, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Deprecate asyncio policy system #127949

📚 Documentation preview 📚: https://cpython-previews--128269.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
start adding docs
e6cf4ae
@kumaraditya303 kumaraditya303 added topic-asyncio skip news labels Dec 26, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 26, 2024
Deprecate asyncio policy system #127949
Closed
7 tasks done
@bedevere-app bedevere-app Bot added the docs Documentation in the Doc dir label Dec 26, 2024
kumaraditya303 added 3 commits December 26, 2024 09:42
@kumaraditya303
whatsnew
2a78312
@kumaraditya303
add missing set_event_loop
48f277b
@kumaraditya303
change example to SelectorEventLoop
b0ad3ef
@kumaraditya303
kumaraditya303 marked this pull request as ready for review December 26, 2024 09:50
@kumaraditya303
kumaraditya303 requested review from 1st1, asvetlov and willingc as code owners December 26, 2024 09:50
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 26, 2024
@kumaraditya303
kumaraditya303 requested a review from hugovk December 26, 2024 09:55
jnts1984
jnts1984 approved these changes Dec 26, 2024
View reviewed changes
picnixz
picnixz reviewed Dec 26, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 @picnixz
Apply suggestions from code review
f057f8f 
Co-authored-by: Bénédikt Tran <[email protected]>
kumaraditya303
kumaraditya303 commented Dec 26, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
Update Doc/whatsnew/3.14.rst
d0a59dd
picnixz
picnixz approved these changes Dec 26, 2024
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you want to add .. deprecated to every class and functions you mentioned, you can do it but since you deprecated the entire module in one go, I don't know if it's worth it or not. The only reason why I would suggest this is for users that do an online search and for IDEs that render Python docs based on the remote docs and that would miss the top-level warning.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303

kumaraditya303 commented Dec 26, 2024

Copy link
Copy Markdown
Contributor Author

If you want to add .. deprecated to every class and functions you mentioned, you can do it but since you deprecated the entire module in one go, I don't know if it's worth it or not.

That was already done as part of individual PRs.

image
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Dec 26, 2024

Copy link
Copy Markdown
Member

Perfect! (sorry since the diff didn't show it I wasn't aware of; I thought you waited for those changes actually or I didn't remember this). My approval remains then.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eclips4
Eclips4 approved these changes Dec 26, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 26, 2024
@kumaraditya303
kumaraditya303 merged commit 3eb746a into python:main Dec 26, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 26, 2024
@kumaraditya303
kumaraditya303 deleted the docs branch December 26, 2024 14:32
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@kumaraditya303 @srinivasreddy
pythongh-127949: add docs for asyncio policy deprecation (python#128269)
dc60148
@picnixz picnixz mentioned this pull request Mar 12, 2025
asyncio.events.BaseDefaultEventLoopPolicy gone from Python 3.14 without prior deprecation #131148
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes
@Eclips4 Eclips4 Eclips4 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner
@hugovk hugovk Awaiting requested review from hugovk
+1 more reviewer
@jnts1984 jnts1984 jnts1984 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-asyncio

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@kumaraditya303 @picnixz @asvetlov @jnts1984 @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.