GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128277: make globals variables thread safe in socket module by kumaraditya303 · Pull Request #128286 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Dec 27, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

First part of making socket module thread safe by moving state variables to be globally thread safe.

  • Issue: Make socket module thread safe #128277

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
make flags thread safe
cdd1eea
@kumaraditya303 kumaraditya303 added skip news topic-free-threading labels Dec 27, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 27, 2024
Make socket module thread safe #128277
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 27, 2024
@kumaraditya303
fix globals-to-fix.tsv
8c1d1b4
@kumaraditya303
kumaraditya303 requested a review from ericsnowcurrently as a code owner December 27, 2024 11:46
kumaraditya303 added 4 commits December 28, 2024 07:25
@kumaraditya303
try
6809619
@kumaraditya303
fix c analyzer
f330202
@kumaraditya303
fmt
2463bbd
@kumaraditya303
fix fileutils
ef6f457
@kumaraditya303
kumaraditya303 force-pushed the socket-threadsafe branch from 1e6f9e5 to ef6f457 Compare December 28, 2024 08:00
@corona10
corona10 requested a review from colesbury December 28, 2024 08:10
erlend-aasland
erlend-aasland reviewed Dec 30, 2024
View reviewed changes
Comment thread Modules/socketmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
colesbury
colesbury reviewed Dec 30, 2024
View reviewed changes
Comment thread Modules/socketmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/socketmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303 added 4 commits December 31, 2024 09:14
@kumaraditya303
remove macros
9c54376
@kumaraditya303
remove ft_ macros
0b5b22f
@kumaraditya303
fix globals to fix
12eeb63
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into socket-…
808e3d1 
…threadsafe
erlend-aasland
erlend-aasland approved these changes Dec 31, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 31, 2024
@kumaraditya303
kumaraditya303 merged commit e389d6c into python:main Dec 31, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 31, 2024
@kumaraditya303
kumaraditya303 deleted the socket-threadsafe branch December 31, 2024 13:40
WolframAlph pushed a commit to WolframAlph/cpython that referenced this pull request Dec 31, 2024
@kumaraditya303 @WolframAlph
pythongh-128277: make globals variables thread safe in socket module (p…
51a2015 
…ython#128286)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@kumaraditya303 @srinivasreddy
pythongh-128277: make globals variables thread safe in socket module (p…
6850cab 
…ython#128286)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kumaraditya303 @colesbury @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.