GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128277: remove unnecessary critical section from `socket.close` by kumaraditya303 · Pull Request #128305 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Dec 28, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Make socket module thread safe #128277

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kumaraditya303 added 2 commits December 28, 2024 09:52
@kumaraditya303
use relaxed atomics for sock_fd
256afa6
@kumaraditya303
remove critical section from close
b95ed4c
@kumaraditya303 kumaraditya303 added the skip news label Dec 28, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 28, 2024
Make socket module thread safe #128277
Closed
@kumaraditya303 kumaraditya303 added the topic-free-threading label Dec 28, 2024
kumaraditya303 added 3 commits December 28, 2024 15:29
@kumaraditya303
add test
3774f5d
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into nocr
3bfaec9
@kumaraditya303
resolve merge
1ae58fe
@kumaraditya303
kumaraditya303 marked this pull request as ready for review January 1, 2025 12:18
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 1, 2025
@kumaraditya303
kumaraditya303 merged commit bb9d955 into python:main Jan 1, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 1, 2025
@kumaraditya303
kumaraditya303 deleted the nocr branch January 1, 2025 12:32
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@kumaraditya303 @srinivasreddy
pythongh-128277: remove unnecessary critical section from `socket.clo…
bc07e75 
…se` (python#128305)

Remove unnecessary critical section from `socket.close` as it now uses relaxed atomics for `sock_fd`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.