GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128317: Document `calendar.TextCalendar.formatweek` by hugovk · Pull Request #128353 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Dec 30, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Split from https://github.com/python/cpython/pull/128318/files#r1899194979 for backporting.

  • Issue: Highlight today in colour in calendar's CLI output #128317

📚 Documentation preview 📚: https://cpython-previews--128353.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Document calendar.TextCalendar.formatweek
5d860d2
@bedevere-app bedevere-app Bot mentioned this pull request Dec 30, 2024
Highlight today in colour in calendar's CLI output #128317
Closed
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting core review labels Dec 30, 2024
@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Dec 30, 2024
@hugovk hugovk mentioned this pull request Dec 30, 2024
gh-128317: Highlight today in colour in calendar CLI output #128318
Merged
erlend-aasland
erlend-aasland approved these changes Dec 30, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 30, 2024
@erlend-aasland

erlend-aasland commented Dec 30, 2024

Copy link
Copy Markdown
Contributor

See also #108202.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk merged commit 6dbace3 into python:main Dec 30, 2024
@hugovk
hugovk deleted the 3.14-update-calendar-docs branch December 30, 2024 17:25
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 30, 2024
@miss-islington-app

miss-islington-app Bot commented Dec 30, 2024

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2024
@hugovk @miss-islington
pythongh-128317: Document calendar.TextCalendar.formatweek (pythonG…
405bc72 
…H-128353)

(cherry picked from commit 6dbace3)

Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2024
@hugovk @miss-islington
pythongh-128317: Document calendar.TextCalendar.formatweek (pythonG…
7fc308a 
…H-128353)

(cherry picked from commit 6dbace3)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Dec 30, 2024

Copy link
Copy Markdown

GH-128357 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Dec 30, 2024
@bedevere-app

bedevere-app Bot commented Dec 30, 2024

Copy link
Copy Markdown

GH-128358 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 30, 2024
@hugovk hugovk mentioned this pull request Dec 30, 2024
Docs: the calendar module lacks documentation for several APIs #108202
Open
hugovk added a commit that referenced this pull request Dec 30, 2024
@miss-islington @hugovk
[3.13] gh-128317: Document calendar.TextCalendar.formatweek (GH-128353
207a81a 
) (#128357)

Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Dec 30, 2024
@miss-islington @hugovk
[3.12] gh-128317: Document calendar.TextCalendar.formatweek (GH-128353
b22d0fc 
) (#128358)

Co-authored-by: Hugo van Kemenade <[email protected]>
@StanFromIreland

StanFromIreland commented Dec 30, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Hello @hugovk and @erlend-aasland , this was already in my PR #108202 what should I do?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Dec 30, 2024

Copy link
Copy Markdown
Member Author

PR #127608? Let's continue over there.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hugovk @srinivasreddy
pythongh-128317: Document calendar.TextCalendar.formatweek (python#…
d665607 
…128353)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @erlend-aasland @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.