GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 requirements (GH-128322) by miss-islington · Pull Request #128355 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Dec 30, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 81376fe)

Co-authored-by: Zanie Blue [email protected]
Co-authored-by: Erlend E. Aasland [email protected]

  • Issue: Statically linked sqlite3 fails checks due to missing -lm #128321

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zanieb @erlend-aasland @miss-islington
pythongh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 re…
e41e503 
…quirements (pythonGH-128322)

(cherry picked from commit 81376fe)

Co-authored-by: Zanie Blue <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
@miss-islington
miss-islington requested review from corona10 and erlend-aasland as code owners December 30, 2024 17:25
@bedevere-app bedevere-app Bot mentioned this pull request Dec 30, 2024
Statically linked sqlite3 fails checks due to missing -lm #128321
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Dec 30, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 30, 2024
gh-128321: Set LIBS instead of LDFLAGS during sqlite3 library build checks #128322
Merged
erlend-aasland
erlend-aasland approved these changes Dec 30, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 30, 2024
@erlend-aasland
erlend-aasland enabled auto-merge (squash) December 30, 2024 17:26
@erlend-aasland
erlend-aasland merged commit 4ddee55 into python:3.12 Dec 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 30, 2024
@solvingj solvingj mentioned this pull request Feb 4, 2025
checking for stdlib extension module _sqlite3... missing codrsquad/portable-python#58
Closed
@miss-islington
miss-islington deleted the backport-81376fe-3.12 branch January 2, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @erlend-aasland @zanieb
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.