GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128321: Set `LIBS` instead of `LDFLAGS` during sqlite3 library build checks by zanieb · Pull Request #128322 · python/cpython

Conversation

@zanieb

@zanieb zanieb commented Dec 29, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Closes #128321

See the issue for context.

There are a few alternative approaches we could take, such as:

  • Always including -lm during checks (which would over-link)
  • Using PKG_CHECK_MODULES_STATIC instead of PKG_CHECK_MODULES when shared libraries are disabled

I'm not really sure of the trade-offs. This seems like the simplest approach to unblock users who can set PKG_CONFIG to include the --static flag as mentioned in https://bugs.freedesktop.org/show_bug.cgi?id=19541#c7

  • Issue: Statically linked sqlite3 fails checks due to missing -lm #128321

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zanieb
Set LIBS during sqlite3 library build checks
478374c
@bedevere-app bedevere-app Bot mentioned this pull request Dec 29, 2024
Statically linked sqlite3 fails checks due to missing -lm #128321
Closed
erlend-aasland
erlend-aasland reviewed Dec 29, 2024
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland reviewed Dec 30, 2024
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland @zanieb
Use LIBS iso. LDFLAGS for sqlite3 func checks
2fea651
@zanieb zanieb changed the title gh-128321: Set LIBS during sqlite3 library build checks gh-128321: Set LIBS instead of LDFLAGS during sqlite3 library build checks Dec 30, 2024
@zanieb
Update news blurb
0f2f2c9
@zanieb
zanieb marked this pull request as ready for review December 30, 2024 05:24
@zanieb
zanieb requested a review from corona10 as a code owner December 30, 2024 05:24
@bedevere-app bedevere-app Bot added the awaiting review label Dec 30, 2024
erlend-aasland
erlend-aasland approved these changes Dec 30, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 30, 2024
@erlend-aasland
erlend-aasland merged commit 81376fe into python:main Dec 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 30, 2024
@zanieb

zanieb commented Dec 30, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the review!
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Dec 30, 2024
Configure pkg-config during CPython builds astral-sh/python-build-standalone#460
Merged
LDFLAGS and LIBS not used consistently in configure #128354
Closed
@erlend-aasland erlend-aasland added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Dec 30, 2024
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2024
@zanieb @erlend-aasland @miss-islington
pythongh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 re…
e41e503 
…quirements (pythonGH-128322)

(cherry picked from commit 81376fe)

Co-authored-by: Zanie Blue <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2024
@zanieb @erlend-aasland @miss-islington
pythongh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 re…
cd6a879 
…quirements (pythonGH-128322)

(cherry picked from commit 81376fe)

Co-authored-by: Zanie Blue <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-app

bedevere-app Bot commented Dec 30, 2024

Copy link
Copy Markdown

GH-128355 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 30, 2024
@bedevere-app

bedevere-app Bot commented Dec 30, 2024

Copy link
Copy Markdown

GH-128356 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Dec 30, 2024
erlend-aasland added a commit that referenced this pull request Dec 30, 2024
@miss-islington @zanieb @erlend-aasland
[3.12] gh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 r…
4ddee55 
…equirements (GH-128322) (#128355)

(cherry picked from commit 81376fe)

Co-authored-by: Zanie Blue <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Dec 30, 2024
@miss-islington @zanieb @erlend-aasland
[3.13] gh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 r…
5a892cb 
…equirements (GH-128322) (#128356)

(cherry picked from commit 81376fe)

Co-authored-by: Zanie Blue <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@zanieb @erlend-aasland @srinivasreddy
pythongh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 re…
bcfcbb7 
…quirements (python#128322)

Co-authored-by: Erlend E. Aasland <[email protected]>
@solvingj solvingj mentioned this pull request Feb 4, 2025
checking for stdlib extension module _sqlite3... missing codrsquad/portable-python#58
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Statically linked sqlite3 fails checks due to missing -lm

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@zanieb @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.