GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-128437: Add `BOLT_COMMON_FLAGS` with `-update-debug-sections` by zanieb · Pull Request #128455 · python/cpython

Conversation

zanieb commented Jan 3, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Adds a common flags variable that is used for both instrument and apply steps. Adds -update-debug-sections to the instrument step to resolve the BOLT warning.

This patch was originally authored by @indygreg as part of astral-sh/python-build-standalone#463

I dropped some additions to BOLT_COMMON_FLAGS, but will add them in a subsequent pull request.

Closes #128437

Issue: Bolt instrumentation missing -update-debug-sections #128437

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

b-long reacted with heart emoji

All reactions

❤️ 1 reaction


          Add BOLT_COMMON_FLAGS with -update-debug-sections

88eef21

Co-authored-by: Gregory Szorc <[email protected]>

zanieb requested review from corona10 and erlend-aasland as code owners

January 3, 2025 18:20

bedevere-app Bot mentioned this pull request

Jan 3, 2025

Bolt instrumentation missing -update-debug-sections #128437

Closed

bedevere-app Bot added the awaiting review label

Jan 3, 2025

zanieb commented Jan 3, 2025

Copy link

Copy Markdown

Contributor Author

I don't believe this needs a news entry.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added the skip news label

Jan 3, 2025

erlend-aasland assigned corona10

Jan 3, 2025


          Merge branch 'main' into zb/bolt-common

ee9a852

zanieb mentioned this pull request

Jan 4, 2025

BOLT fails with --enabled-shared on LLVM 19 with "unable to get new address" #128472

Closed

zanieb commented Jan 4, 2025

Copy link

Copy Markdown

Contributor Author

As mentioned, the BOLT_COMMON_FLAGS will be subsequently used to fix #128472, e.g., zanieb@5448cd9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

corona10 approved these changes

Jan 5, 2025

View reviewed changes

corona10 left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zanieb reacted with heart emoji

All reactions

❤️ 1 reaction

bedevere-app Bot added awaiting merge and removed awaiting review labels

Jan 5, 2025

corona10 merged commit b60044b into python:main

Jan 5, 2025

bedevere-app Bot removed the awaiting merge label

Jan 5, 2025

zanieb added needs backport to 3.12

only security fixes

needs backport to 3.13 only security fixes labels

Jan 5, 2025

miss-islington-app Bot commented Jan 5, 2025

Copy link

Copy Markdown

Thanks @zanieb for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Jan 5, 2025

Copy link

Copy Markdown

Thanks @zanieb for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 5, 2025


          pythongh-128437: Add BOLT_COMMON_FLAGS with -update-debug-sections (

312b99a

pythongh-128455)

Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`

(cherry picked from commit b60044b)

Co-authored-by: Zanie Blue <[email protected]>
Co-authored-by: Gregory Szorc <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 5, 2025


          pythongh-128437: Add BOLT_COMMON_FLAGS with -update-debug-sections (

2eb9a8d

pythongh-128455)

Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`

(cherry picked from commit b60044b)

Co-authored-by: Zanie Blue <[email protected]>
Co-authored-by: Gregory Szorc <[email protected]>

bedevere-app Bot commented Jan 5, 2025

Copy link

Copy Markdown

GH-128512 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Jan 5, 2025

bedevere-app Bot commented Jan 5, 2025

Copy link

Copy Markdown

GH-128513 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Jan 5, 2025

zanieb mentioned this pull request

Jan 5, 2025

gh-128472: Add -skip-funcs to BOLT options to fix computed goto errors #128511

Merged

corona10 pushed a commit that referenced this pull request

Jan 5, 2025


          [3.13] gh-128437: Add BOLT_COMMON_FLAGS with `-update-debug-section…

40fd466

…s` (gh-128455) (gh-128512)

gh-128437: Add `BOLT_COMMON_FLAGS` with `-update-debug-sections` (gh-128455)

Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`

(cherry picked from commit b60044b)

Co-authored-by: Zanie Blue <[email protected]>
Co-authored-by: Gregory Szorc <[email protected]>

corona10 pushed a commit that referenced this pull request

Jan 5, 2025


          [3.12] gh-128437: Add BOLT_COMMON_FLAGS with `-update-debug-section…

90535fe

…s` (gh-128455) (gh-128513)

gh-128437: Add `BOLT_COMMON_FLAGS` with `-update-debug-sections` (gh-128455)

Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`

(cherry picked from commit b60044b)

Co-authored-by: Zanie Blue <[email protected]>
Co-authored-by: Gregory Szorc <[email protected]>

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request

Jan 6, 2025


          pythongh-128437: Add BOLT_COMMON_FLAGS with -update-debug-sections (

7f767cd

pythongh-128455)

Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`

Co-authored-by: Gregory Szorc <[email protected]>

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request

Jan 8, 2025


          pythongh-128437: Add BOLT_COMMON_FLAGS with -update-debug-sections (

f7e8436

pythongh-128455)

Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`

Co-authored-by: Gregory Szorc <[email protected]>

Reviewers

corona10

corona10 approved these changes

erlend-aasland

Awaiting requested review from erlend-aasland

erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

corona10

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bolt instrumentation missing -update-debug-sections

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

zanieb commented Jan 3, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zanieb commented Jan 3, 2025

Uh oh!

zanieb commented Jan 4, 2025

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Jan 5, 2025

Uh oh!

miss-islington-app Bot commented Jan 5, 2025

Uh oh!

bedevere-app Bot commented Jan 5, 2025

Uh oh!

bedevere-app Bot commented Jan 5, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zanieb commented Jan 3, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.