GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-128354: Consistently use LIBS over LDFLAGS in library build… by zanieb · Pull Request #128466 · python/cpython

Conversation

@zanieb

@zanieb zanieb commented Jan 4, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

… checks (GH-128359)

(cherry picked from commit b75ed95)

ref #128359 (comment)

  • Issue: LDFLAGS and LIBS not used consistently in configure #128354

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@zanieb
[3.12] pythongh-128354: Consistently use LIBS over LDFLAGS in library…
789f6cf 
… build checks (pythonGH-128359)

(cherry picked from commit b75ed95)

Co-authored-by: Zanie Blue <[email protected]>
@zanieb
zanieb requested review from corona10 and erlend-aasland as code owners January 4, 2025 00:30
@bedevere-app bedevere-app Bot mentioned this pull request Jan 4, 2025
LDFLAGS and LIBS not used consistently in configure #128354
Closed
@bedevere-app bedevere-app Bot added the skip news label Jan 4, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 4, 2025
gh-128354: Use LIBS consistently over LDFLAGS in library build checks #128359
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jan 4, 2025
@erlend-aasland
erlend-aasland enabled auto-merge (squash) January 4, 2025 00:31
@erlend-aasland
erlend-aasland merged commit f2cc565 into python:3.12 Jan 4, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@zanieb @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.