Description

zanieb

opened on Dec 30, 2024

Issue body actions

Bug report

Bug description:

Following up on #128322, I noticed that the same pattern of setting LDFLAGS instead of LIBS is used frequently. Additionally, there is not consistency in the ordering of the added libraries, e.g., LIBS="$LIBS ..." vs LIBS="... $LIBS".

For cases where the linking order matters, I believe using LDFLAGS is incorrect and the existing $LIBS should always come first.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

• gh-128354: Use LIBS consistently over LDFLAGS in library build checks #128359
• [3.13] gh-128354: Consistently use LIBS over LDFLAGS in library build… #128465
• [3.12] gh-128354: Consistently use LIBS over LDFLAGS in library build… #128466

Reacted by Erlend E. Aasland

Activity

1. zanieb

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Dec 30, 2024
2. erlend-aasland

   added

   buildThe build process and cross-buildThe build process and cross-build

   on Dec 30, 2024
3. erlend-aasland

   added a commit that references this issue on Jan 3, 2025

   gh-128354: Consistently use LIBS over LDFLAGS in library build checks (…

   b75ed95
4. zanieb

   added 2 commits that reference this issue on Jan 4, 2025

   [3.13] pythongh-128354: Consistently use LIBS over LDFLAGS in library…

   f6b30a5

   [3.12] pythongh-128354: Consistently use LIBS over LDFLAGS in library…

   789f6cf
5. erlend-aasland

   added 2 commits that reference this issue on Jan 4, 2025

   [3.12] gh-128354: Consistently use LIBS over LDFLAGS in library build… (

   f2cc565

   [3.13] gh-128354: Consistently use LIBS over LDFLAGS in library build… (

   855af3b
6. WolframAlph

   added a commit that references this issue on Jan 4, 2025

   pythongh-128354: Consistently use LIBS over LDFLAGS in library build …

   29bd2e5
7. srinivasreddy

   added a commit that references this issue on Jan 8, 2025

   pythongh-128354: Consistently use LIBS over LDFLAGS in library build …

   7d4e098
8. erlend-aasland

   closed this as completedon Jan 8, 2025
9. hugovk commented on Jan 8, 2025

   

   hugovk

   on Jan 8, 2025

   Member

   More actions

   @zanieb Thanks for the PR, now merged and backported! Can we close this issue now?

Issue actions