GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127146: skip Emscripten tests with pending fixes by hoodmane · Pull Request #128549 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Jan 6, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Skip some tests failures that are either fixed on the main branch of Emscripten or by an open PR.

  • Issue: Emscripten: Get test suite passing #127146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
pythongh-127146: skip some tests that are fixed on the main branch of…
7e77e68 
… Emscripten
@hoodmane
hoodmane requested a review from freakboy3742 January 6, 2025 14:15
@hoodmane
hoodmane requested review from brettcannon, ericsnowcurrently, ethanfurman, ncoghlan and warsaw as code owners January 6, 2025 14:15
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jan 6, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 6, 2025
Emscripten: Get test suite passing #127146
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jan 6, 2025
@hoodmane hoodmane added the skip news label Jan 6, 2025
@hoodmane
Skip two more tests which are fixed by a pending Emscripten PR
a8bbec5
@hoodmane hoodmane changed the title gh-127146: skip tests that are fixed on the main branch of Emscripten gh-127146: skip Emscripten tests with pending fixes Jan 6, 2025
hoodmane added 2 commits January 6, 2025 15:35
@hoodmane
Revert "Skip two more tests which are fixed by a pending Emscripten PR"
b1d36b1 
This reverts commit a8bbec5.
@hoodmane
Add reference to fix for pipe i/o
d03adfb
@brettcannon
brettcannon removed their request for review January 6, 2025 17:26
@hoodmane
Add reference to fix for setting time to 0
0e7f1f3
freakboy3742
freakboy3742 approved these changes Jan 6, 2025
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 6, 2025
@freakboy3742
freakboy3742 merged commit 616692d into python:main Jan 6, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 6, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Skip Emscripten tests with pending fixes (python#128549
9c5b386 
)

Marks some additional tests as skipped on Emscripten. Many of these skips can be
reverted when the next Emscripten release is available.
@hoodmane
hoodmane deleted the emscripten-main-branch-fixed branch January 8, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes
@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hoodmane @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.