GeezerVison is showing github.com — GH-127178: improve compatibility in `_sysconfig_vars_(...).json` by FFY00 · Pull Request #128558 · python/cpython
Conversation
FFY00
commented
Jan 6, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This patch improves environment and platform compatibility:
- Data now matches
sysconfig.get_config_vars after install
userbase now correctly reflects the target platform when cross-compilingtest_sysconfigdata_json now takes into account the following situations:
- Running with a non-default
sys.executable path
- Running under virtual environments
- Running under relocatable installs
To simplify the detection of relocatable installs, which needs to look at _sysconfigdata_(...), this module is now saved in sys.modules. As part of this change, the code to import the module from a specific directory was refactored to use PathFinder, simplifying the implementation.
Signed-off-by: Filipe Laíns <[email protected]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This patch improves environment and platform compatibility
- Data now matches `sysconfig.get_config_vars` after install
- `userbase` now correctly reflects the target platform when cross-compiling
- `test_sysconfigdata_json` now takes into account the following situations:
- Running with a non-default sys.executable path
- Running under virtual environments
- Running under relocatable installs
To simplify the detection of relocatable installs, which needs to look
at `_sysconfigdata_(...)`, this module is now saved in `sys.modules`.
As part of this change, the code to import the module from a specific
directory was refactored to use `PathFinder`, simplifying the
implementation.
Signed-off-by: Filipe Laíns <[email protected]
|
🤖 New build scheduled with the buildbot fleet by @FFY00 for commit b72a436 🤖
If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @FFY00 for commit 396ac89 🤖
If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jan 29, 2025
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|