GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97850: Suggest `TraversableResources` as the alternative for `ResourceLoader`. by tomasr8 · Pull Request #128601 · python/cpython

Conversation

@tomasr8

@tomasr8 tomasr8 commented Jan 7, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Previously, ResourceReader was the suggested alternative, but it
is itself deprecated in favour of TraversableResources.

More discussion is here: #97850 (comment)

  • Issue: Meta issue for cleaning up import system cruft #97850

📚 Documentation preview 📚: https://cpython-previews--128601.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tomasr8
Suggest TraversableResources as the alternative for ResourceLoader.
e8ad701 
Previously, ResourceReader was the suggested alternative, but it
is itself deprecated in favour of TraversableResources.
@tomasr8 tomasr8 added the skip news label Jan 7, 2025
@tomasr8
tomasr8 requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners January 7, 2025 23:21
@bedevere-app bedevere-app Bot mentioned this pull request Jan 7, 2025
Meta issue for cleaning up import system cruft #97850
Open
25 of 31 tasks
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir awaiting review labels Jan 7, 2025
@tomasr8 tomasr8 added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jan 8, 2025
StanFromIreland
StanFromIreland approved these changes Jan 8, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Jan 8, 2025
@tomasr8
tomasr8 requested a review from jaraco January 9, 2025 08:48
@brettcannon
brettcannon removed their request for review January 9, 2025 18:00
@tomasr8 tomasr8 mentioned this pull request Jan 15, 2025
gh-121604: Make sure all deprecated items in importlib raise DeprecationWarning #128007
Merged
brettcannon
brettcannon approved these changes Jan 15, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 15, 2025
@brettcannon
brettcannon merged commit 256d6d2 into python:main Jan 15, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 15, 2025

Copy link
Copy Markdown

Thanks @tomasr8 for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 15, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 15, 2025
@tomasr8 @miss-islington
pythongh-97850: Suggest TraversableResources as the alternative for…
aae3b50 
… `ResourceLoader` (pythonGH-128601)

Suggest TraversableResources as the alternative for ResourceLoader.

Previously, ResourceReader was the suggested alternative, but it
is itself deprecated in favour of TraversableResources.
(cherry picked from commit 256d6d2)

Co-authored-by: Tomas R. <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 15, 2025

Copy link
Copy Markdown

GH-128895 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 15, 2025
@tomasr8 @miss-islington
pythongh-97850: Suggest TraversableResources as the alternative for…
d095616 
… `ResourceLoader` (pythonGH-128601)

Suggest TraversableResources as the alternative for ResourceLoader.

Previously, ResourceReader was the suggested alternative, but it
is itself deprecated in favour of TraversableResources.
(cherry picked from commit 256d6d2)

Co-authored-by: Tomas R. <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 15, 2025
@bedevere-app

bedevere-app Bot commented Jan 15, 2025

Copy link
Copy Markdown

GH-128896 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 15, 2025
brettcannon pushed a commit that referenced this pull request Jan 15, 2025
@miss-islington @tomasr8
[3.13] gh-97850: Suggest TraversableResources as the alternative fo…
714b851 
…r `ResourceLoader` (GH-128601) (GH-128895)

gh-97850: Suggest `TraversableResources` as the alternative for `ResourceLoader` (GH-128601)

Suggest TraversableResources as the alternative for ResourceLoader.

Previously, ResourceReader was the suggested alternative, but it
is itself deprecated in favour of TraversableResources.
(cherry picked from commit 256d6d2)

Co-authored-by: Tomas R <[email protected]>
brettcannon pushed a commit that referenced this pull request Jan 15, 2025
@miss-islington @tomasr8
[3.12] gh-97850: Suggest TraversableResources as the alternative fo…
0308bcf 
…r `ResourceLoader` (GH-128601) (GH-128896)

gh-97850: Suggest `TraversableResources` as the alternative for `ResourceLoader` (GH-128601)

Suggest TraversableResources as the alternative for ResourceLoader.

Previously, ResourceReader was the suggested alternative, but it
is itself deprecated in favour of TraversableResources.
(cherry picked from commit 256d6d2)

Co-authored-by: Tomas R <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@jaraco jaraco Awaiting requested review from jaraco

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tomasr8 @brettcannon @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.