GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97850: Remove the mention of removal from `ResourceReader` docs by tomasr8 · Pull Request #128602 · python/cpython

Conversation

@tomasr8

@tomasr8 tomasr8 commented Jan 7, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There is currently no plan to remove ResourceReader, especially given that the suggested alternative TraversableResources inherits from ResourceReader. Let's remove the mention of a removal for now.

Related discussion: #97850 (comment)

  • Issue: Meta issue for cleaning up import system cruft #97850

📚 Documentation preview 📚: https://cpython-previews--128602.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tomasr8
Remove the mention of removal from ResourceReader docs
c9dfad3
@tomasr8 tomasr8 added the skip news label Jan 7, 2025
@tomasr8
tomasr8 requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners January 7, 2025 23:29
@bedevere-app bedevere-app Bot mentioned this pull request Jan 7, 2025
Meta issue for cleaning up import system cruft #97850
Open
25 of 31 tasks
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir awaiting review labels Jan 7, 2025
@tomasr8 tomasr8 added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jan 8, 2025
@hugovk

hugovk commented Jan 8, 2025

Copy link
Copy Markdown
Member

Also remove mention of removal from https://github.com/python/cpython/blob/main/Doc/deprecations/pending-removal-in-3.14.rst?
tomasr8 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tomasr8

tomasr8 commented Jan 8, 2025

Copy link
Copy Markdown
Member Author

Also remove mention of removal from https://github.com/python/cpython/blob/main/Doc/deprecations/pending-removal-in-3.14.rst?

Yes, I missed that one. I'll update the PR in a bit!
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented Jan 8, 2025

Copy link
Copy Markdown
Member

@tomasr8 Done for you :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tomasr8

tomasr8 commented Jan 8, 2025

Copy link
Copy Markdown
Member Author

Oh wait, that is the other ResourceReader that was actually removed in 3.14 (from importlib.abc). This PR updates the one in importlib.resources.abc which still exists. So there should be no need to update that document you mentioned Hugo.

Sorry for the confusion @StanFromIreland, I should've checked better :/ but thanks for the help!
StanFromIreland, jaraco, and hugovk reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon
brettcannon removed their request for review January 8, 2025 21:00
@tomasr8
tomasr8 requested a review from jaraco January 8, 2025 22:12
jaraco
jaraco approved these changes Jan 8, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 8, 2025
@jaraco
jaraco merged commit a1284e9 into python:main Jan 8, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 8, 2025

Copy link
Copy Markdown

Thanks @tomasr8 for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 8, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2025
@tomasr8 @miss-islington
pythongh-97850: Remove the mention of removal from ResourceReader d…
7b969fe 
…ocs (pythonGH-128602)

Remove the mention of removal from ResourceReader docs
(cherry picked from commit a1284e9)

Co-authored-by: Tomas R. <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2025
@tomasr8 @miss-islington
pythongh-97850: Remove the mention of removal from ResourceReader d…
788ddc4 
…ocs (pythonGH-128602)

Remove the mention of removal from ResourceReader docs
(cherry picked from commit a1284e9)

Co-authored-by: Tomas R. <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 8, 2025

Copy link
Copy Markdown

GH-128654 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 8, 2025
@bedevere-app

bedevere-app Bot commented Jan 8, 2025

Copy link
Copy Markdown

GH-128655 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 8, 2025
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
@tomasr8

tomasr8 commented Jan 9, 2025

Copy link
Copy Markdown
Member Author

The buildbot failure is unrelated (it's in test_multiprocessing_forkserver while this PR only touches the docs)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ambv pushed a commit that referenced this pull request Jan 23, 2025
@miss-islington @tomasr8
[3.13] gh-97850: Remove the mention of removal from ResourceReader …
eed7865 
…docs (GH-128602) (#128654)

gh-97850: Remove the mention of removal from `ResourceReader` docs (GH-128602)

Remove the mention of removal from ResourceReader docs
(cherry picked from commit a1284e9)

Co-authored-by: Tomas R <[email protected]>
Yhg1s pushed a commit that referenced this pull request Feb 3, 2025
@miss-islington @tomasr8
[3.12] gh-97850: Remove the mention of removal from ResourceReader …
4879257 
…docs (GH-128602) (#128655)

gh-97850: Remove the mention of removal from `ResourceReader` docs (GH-128602)

Remove the mention of removal from ResourceReader docs
(cherry picked from commit a1284e9)

Co-authored-by: Tomas R <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently
@ncoghlan ncoghlan Awaiting requested review from ncoghlan
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tomasr8 @hugovk @StanFromIreland @bedevere-bot @jaraco
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.