GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — decimal docs: specification link and examples by skirpichev · Pull Request #128698 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented Jan 10, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • added a direct reference to a floating-point model used
  • and few examples for formatted string output

📚 Documentation preview 📚: https://cpython-previews--128698.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skirpichev
decimal docs: specification link and examples
7a335ed 
* added a direct reference to a floating-point model used
* and few examples for formatted string output
@skirpichev skirpichev added skip issue skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jan 10, 2025
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir awaiting review labels Jan 10, 2025
@skirpichev skirpichev mentioned this pull request Jan 10, 2025
Decimal('0.0000005').quantize(Decimal('1.1111111')) -> Decimal('5E-7') # should be unchanged #128373
Closed
rruuaanng
rruuaanng reviewed Jan 10, 2025
View reviewed changes
Comment thread Doc/library/decimal.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
skirpichev and others added 2 commits January 10, 2025 09:16
@skirpichev @rruuaanng
Update Doc/library/decimal.rst
a66b20a 
Co-authored-by: RUANG (James Roy) <[email protected]>
@skirpichev
+ fix sphinx markup; sorry I was in md mode)
228091a
StanFromIreland
StanFromIreland reviewed Jan 10, 2025
View reviewed changes
Comment thread Doc/library/decimal.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland
StanFromIreland reviewed Jan 10, 2025
View reviewed changes
Comment thread Doc/library/decimal.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland
StanFromIreland reviewed Jan 10, 2025
View reviewed changes
Comment thread Doc/library/decimal.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev @StanFromIreland
Update Doc/library/decimal.rst
6fb60ef 
Co-authored-by: Stan Ulbrych <[email protected]>
@skirpichev
skirpichev requested a review from StanFromIreland January 11, 2025 02:08
StanFromIreland
StanFromIreland approved these changes Jan 11, 2025
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Jan 11, 2025
ericvsmith
ericvsmith reviewed Jan 23, 2025
View reviewed changes
Comment thread Doc/library/decimal.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
skirpichev added 2 commits January 24, 2025 05:25
@skirpichev
Merge branch 'master' into decimal-docs
ad204cb
@skirpichev
address review: refs to format/f-strings, add f-string example
3d402ce
@skirpichev
skirpichev requested a review from ericvsmith January 24, 2025 02:39
@skirpichev

skirpichev commented Jan 24, 2025

Copy link
Copy Markdown
Member Author

@ericvsmith, refs to format/f-strings - added.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericvsmith

ericvsmith commented Jan 28, 2025

Copy link
Copy Markdown
Member

@ericvsmith, refs to format/f-strings - added.

I think that's good. It doesn't mention str.format, but that's not so important any more and I hope that anyone who really cares about it knows that it's all based on __format__.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev

skirpichev commented Jan 28, 2025

Copy link
Copy Markdown
Member Author

It doesn't mention str.format, but that's not so important

I think this will be too verbose, it's already mention the format() builtin docs, which has links to __format__ and then to str.format()
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericvsmith

ericvsmith commented Jan 29, 2025

Copy link
Copy Markdown
Member

It doesn't mention str.format, but that's not so important

I think this will be too verbose, it's already mention the format() builtin docs, which has links to __format__ and then to str.format()

Agreed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev skirpichev mentioned this pull request Apr 7, 2025
gh-130664: support '_' (just as ',') in Decimal's formatting #132155
Merged
@skirpichev skirpichev removed the needs backport to 3.12 only security fixes label Apr 8, 2025
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@skirpichev
skirpichev requested a review from serhiy-storchaka May 25, 2025 09:47
@skirpichev skirpichev mentioned this pull request Jul 14, 2025
, works with Decimal() against the doc of **Format Specification Mini-Language** #136636
Closed
@skirpichev
skirpichev requested a review from AA-Turner July 19, 2025 10:53
hugovk
hugovk reviewed Dec 16, 2025
View reviewed changes
Comment thread Doc/library/decimal.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
Prefer anonymous links
4f607e1
@hugovk
hugovk enabled auto-merge (squash) December 16, 2025 11:34
@hugovk
Merge branch 'main' into decimal-docs
f01da3e
@hugovk
hugovk merged commit 2450be6 into python:main Dec 16, 2025
28 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Dec 16, 2025
@miss-islington-app

miss-islington-app Bot commented Dec 16, 2025

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Dec 16, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
@skirpichev @rruuaanng
@StanFromIreland @hugovk @miss-islington
decimal docs: specification link and examples (pythonGH-128698)
86d8e33 
(cherry picked from commit 2450be6)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: RUANG (James Roy) <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
@skirpichev @rruuaanng
@StanFromIreland @hugovk @miss-islington
decimal docs: specification link and examples (pythonGH-128698)
3a4b5b2 
(cherry picked from commit 2450be6)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: RUANG (James Roy) <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Dec 16, 2025

Copy link
Copy Markdown

GH-142804 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Dec 16, 2025
@bedevere-app

bedevere-app Bot commented Dec 16, 2025

Copy link
Copy Markdown

GH-142805 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Dec 16, 2025
@skirpichev
skirpichev deleted the decimal-docs branch December 16, 2025 11:43
kumaraditya303 pushed a commit that referenced this pull request Dec 17, 2025
@miss-islington @skirpichev
@rruuaanng @StanFromIreland @hugovk
[3.14] decimal docs: specification link and examples (GH-128698) (#14…
ad6396e 
…2804)

decimal docs: specification link and examples (GH-128698)
(cherry picked from commit 2450be6)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: RUANG (James Roy) <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request Dec 17, 2025
@miss-islington @skirpichev
@rruuaanng @StanFromIreland @hugovk
[3.13] decimal docs: specification link and examples (GH-128698) (#14…
e5fd737 
…2805)

decimal docs: specification link and examples (GH-128698)
(cherry picked from commit 2450be6)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: RUANG (James Roy) <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@StanFromIreland StanFromIreland StanFromIreland approved these changes
@ericvsmith ericvsmith Awaiting requested review from ericvsmith
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka
@AA-Turner AA-Turner Awaiting requested review from AA-Turner
+1 more reviewer
@rruuaanng rruuaanng rruuaanng left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@skirpichev @ericvsmith @hugovk @StanFromIreland @rruuaanng @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.