GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update cryptographic primitives code owners. by picnixz · Pull Request #128747 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jan 12, 2025

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
Add @picnixz to cryptographic primitives code owners.
2a85e9b
@picnixz
picnixz requested review from ezio-melotti and hugovk as code owners January 12, 2025 10:36
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 12, 2025
@picnixz picnixz added skip issue skip news labels Jan 12, 2025
hugovk
hugovk approved these changes Jan 12, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 12, 2025
AA-Turner
AA-Turner approved these changes Jan 12, 2025
View reviewed changes
@picnixz

picnixz commented Jan 12, 2025

Copy link
Copy Markdown
Member Author

I don't know why the SBOM regeneration fails on Windows (looks like a network issue) :') Guess I'll just try again a bit later.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Jan 12, 2025

Copy link
Copy Markdown
Member

It is wasteful to run CI on updates to CODEOWNERS, perhaps we should add it to the exclusions here:

cpython/.github/workflows/reusable-change-detection.yml

Lines 69 to 87 in 5ace717

if [ -z "$GITHUB_BASE_REF" ]; then
echo "run-tests=true" >> "$GITHUB_OUTPUT"
else
git fetch origin "$GITHUB_BASE_REF" --depth=1
# git diff "origin/$GITHUB_BASE_REF..." (3 dots) may be more
# reliable than git diff "origin/$GITHUB_BASE_REF.." (2 dots),
# but it requires to download more commits (this job uses
# "git fetch --depth=1").
#
# git diff "origin/$GITHUB_BASE_REF..." (3 dots) works with Git
# 2.26, but Git 2.28 is stricter and fails with "no merge base".
#
# git diff "origin/$GITHUB_BASE_REF.." (2 dots) should be enough on
# GitHub, since GitHub starts by merging origin/$GITHUB_BASE_REF
# into the PR branch anyway.
#
# https://github.com/python/core-workflow/issues/373
git diff --name-only "origin/$GITHUB_BASE_REF.." | grep -qvE '(\.rst$|^Doc|^Misc|^\.pre-commit-config\.yaml$|\.ruff\.toml$|\.md$|mypy\.ini$)' && echo "run-tests=true" >> "$GITHUB_OUTPUT" || true
fi

A
picnixz, FFY00, and Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner AA-Turner mentioned this pull request Jan 12, 2025
Skip CI expensive checks on CODEOWNERS update #128754
Merged
@picnixz

picnixz commented Jan 12, 2025

Copy link
Copy Markdown
Member Author

I'll wait for #128754 to be merged so that we can test it (I'll make an empty commit to trigger the CI).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead
gpshead reviewed Jan 13, 2025
View reviewed changes
Comment thread .github/CODEOWNERS Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz changed the title Add @picnixz to cryptographic primitives code owners. Add @picnixz and @gpshead to cryptographic primitives code owners. Jan 13, 2025
@picnixz
Add @gpshead to HMAC code owners.
347d3e4
@picnixz picnixz changed the title Add @picnixz and @gpshead to cryptographic primitives code owners. Update cryptographic primitives code owners. Jan 13, 2025
@hugovk

hugovk commented Jan 14, 2025

Copy link
Copy Markdown
Member

I'll wait for #128754 to be merged so that we can test it (I'll make an empty commit to trigger the CI).

Now merged.
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
[empty commit] trigger the CI
079efff
@picnixz

picnixz commented Jan 14, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

It looks like the CI is now in a good shape:

image

I guess we're good to go then.
hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
Merge branch 'main' into picnixz-codeowners
75c3aa1
@hugovk
hugovk merged commit eefd4a0 into python:main Jan 14, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 14, 2025
@picnixz
picnixz deleted the picnixz-codeowners branch January 14, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead left review comments
@hugovk hugovk hugovk approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@picnixz @AA-Turner @hugovk @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.