GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Skip CI expensive checks on `CODEOWNERS` update by picnixz · Pull Request #128754 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jan 12, 2025 •
edited by AA-Turner
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

#128747 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
skip CI on CODEOWNERS update
a3fee7c
@picnixz
picnixz requested review from ezio-melotti and hugovk as code owners January 12, 2025 12:33
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 12, 2025
@picnixz picnixz added skip issue skip news infra CI, GitHub Actions, buildbots, Dependabot, etc. labels Jan 12, 2025
@picnixz
fix pattern
608f77f
@picnixz
picnixz requested a review from AA-Turner January 12, 2025 12:37
AA-Turner
AA-Turner approved these changes Jan 12, 2025
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on mobile so cant't test the command, but the pattern looks correct.

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 12, 2025
@picnixz picnixz mentioned this pull request Jan 12, 2025
Update cryptographic primitives code owners. #128747
Merged
@picnixz

picnixz commented Jan 12, 2025

Copy link
Copy Markdown
Member Author

No hurry. I'm no more on my dev session so I'll let Hugo check (I've taken the liberty of splitting the grep command but AFAIR, this should be equivalent)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk reviewed Jan 13, 2025
View reviewed changes
Comment thread .github/workflows/reusable-change-detection.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
Store patterns into an array for readability
5308aea
hugovk
hugovk reviewed Jan 13, 2025
View reviewed changes
Comment thread .github/workflows/reusable-change-detection.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz @hugovk
Update .github/workflows/reusable-change-detection.yml
a3165d6 
Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk
hugovk merged commit 99327d1 into python:main Jan 14, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 14, 2025
@hugovk

hugovk commented Jan 14, 2025

Copy link
Copy Markdown
Member

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz deleted the skip-ci-on-codeowners-changes branch January 14, 2025 09:04
@AA-Turner AA-Turner mentioned this pull request Feb 3, 2025
Convert change detection to a Python script #129627
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@AA-Turner AA-Turner AA-Turner approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

infra CI, GitHub Actions, buildbots, Dependabot, etc. skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@picnixz @hugovk @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.