GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106320: Document private C APIs promoted to public C API by vstinner · Pull Request #128788 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jan 13, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: C API: Remove private C API functions (move them to the internal C API) #106320

📚 Documentation preview 📚: https://cpython-previews--128788.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-106320: Document private C APIs promoted to public C API
eddf0ed
@vstinner vstinner added the skip news label Jan 13, 2025
@bedevere-app bedevere-app Bot added the docs Documentation in the Doc dir label Jan 13, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 13, 2025
C API: Remove private C API functions (move them to the internal C API) #106320
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 13, 2025
@vstinner

vstinner commented Jan 13, 2025

Copy link
Copy Markdown
Member Author

See also #128787.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Jan 13, 2025
gh-106320: Document replacement for removed C API #128787
Merged
clin1234
clin1234 approved these changes Jan 13, 2025
View reviewed changes

@clin1234 clin1234 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skirpichev
skirpichev self-requested a review January 14, 2025 04:02
skirpichev
skirpichev approved these changes Jan 14, 2025
View reviewed changes
@vstinner
vstinner merged commit 41f7350 into python:main Jan 14, 2025
@vstinner
vstinner deleted the promoted_capi branch January 14, 2025 07:44
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichev skirpichev skirpichev approved these changes
+1 more reviewer
@clin1234 clin1234 clin1234 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @skirpichev @clin1234
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.