GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106320: Document replacement for removed C API by vstinner · Pull Request #128787 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jan 13, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: C API: Remove private C API functions (move them to the internal C API) #106320

📚 Documentation preview 📚: https://cpython-previews--128787.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-106320: Document replacement for removed C API
299d662
@vstinner vstinner added skip news needs backport to 3.13 only security fixes labels Jan 13, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 13, 2025
C API: Remove private C API functions (move them to the internal C API) #106320
Closed
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir awaiting core review labels Jan 13, 2025
@vstinner vstinner mentioned this pull request Jan 13, 2025
gh-106320: Document private C APIs promoted to public C API #128788
Merged
@vstinner

vstinner commented Jan 13, 2025

Copy link
Copy Markdown
Member Author

See also #128788.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clin1234
clin1234 suggested changes Jan 13, 2025
View reviewed changes

@clin1234 clin1234 left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps also include a list of other removed private functions that don't have simple replacements for them?

Other than that, LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner

vstinner commented Jan 13, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Perhaps also include a list of other removed private functions that don't have simple replacements for them?

Do you have examples?

Python 3.13 removed 263 private functions. I don't want to give the full list, especially if there is no simple replacement.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland
StanFromIreland reviewed Jan 13, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@clin1234

clin1234 commented Jan 13, 2025

Copy link
Copy Markdown
Contributor
  • _PyErr_WriteUnraisableMsg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner and others added 2 commits January 13, 2025 19:33
@vstinner @StanFromIreland
Update Doc/whatsnew/3.13.rst
cedf3cc 
Co-authored-by: Stan Ulbrych <[email protected]>
@vstinner
Add _PyErr_WriteUnraisableMsg()
b79a6c0
@vstinner

vstinner commented Jan 13, 2025

Copy link
Copy Markdown
Member Author

_PyErr_WriteUnraisableMsg

Ok, I added _PyErr_WriteUnraisableMsg() replaced with PyErr_FormatUnraisable().
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 43ef958 into python:main Jan 14, 2025
@vstinner
vstinner deleted the removed_capi branch January 14, 2025 15:29
@miss-islington-app

miss-islington-app Bot commented Jan 14, 2025

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 14, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 14, 2025
@vstinner @miss-islington
pythongh-106320: Document replacement for removed C API (pythonGH-128787
6baa1d4 
)

(cherry picked from commit 43ef958)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 14, 2025

Copy link
Copy Markdown

GH-128837 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 14, 2025
vstinner added a commit that referenced this pull request Jan 14, 2025
@miss-islington @vstinner
[3.13] gh-106320: Document replacement for removed C API (GH-128787) (#…
d2a8d57 
…128837)

gh-106320: Document replacement for removed C API (GH-128787)
(cherry picked from commit 43ef958)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments
+1 more reviewer
@clin1234 clin1234 clin1234 requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @clin1234 @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.