GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-125722: Increase minimum supported Sphinx to 8.1.3 by AA-Turner · Pull Request #128922 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Jan 16, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Use the latest Sphinx version #125722

📚 Documentation preview 📚: https://cpython-previews--128922.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
m-aciek reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@AA-Turner
pythonGH-125722: Increase minimum supported Sphinx to 8.1.3
a232742
@AA-Turner AA-Turner added docs Documentation in the Doc dir needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jan 16, 2025
@AA-Turner
AA-Turner requested review from ezio-melotti and hugovk as code owners January 16, 2025 19:03
@bedevere-app bedevere-app Bot mentioned this pull request Jan 16, 2025
Use the latest Sphinx version #125722
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 16, 2025
AA-Turner
AA-Turner commented Jan 16, 2025
View reviewed changes
Comment thread Doc/requirements-oldest-sphinx.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner added 2 commits January 16, 2025 19:09
@AA-Turner
Remove redundant code in conf.py
da11ead
@AA-Turner
Remove lower-bounds
02652dc
ezio-melotti
ezio-melotti approved these changes Jan 16, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 16, 2025
AA-Turner added 2 commits January 16, 2025 19:13
@AA-Turner
fixup! Remove lower-bounds
699cd3b
@AA-Turner
Remove the oldest supported sphinx GHA job
280fe7f
@hugovk

hugovk commented Jan 16, 2025

Copy link
Copy Markdown
Member

There's some if sphinx.version_info[:2] < (7, 2): in Doc/tools/extensions/c_annotations.py that can be removed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Remove redundant code in c_annotations
5313bad
@AA-Turner

AA-Turner commented Jan 16, 2025

Copy link
Copy Markdown
Member Author

There's some if sphinx.version_info[:2] < (7, 2): in Doc/tools/extensions/c_annotations.py that can be removed.

Done, I thought I'd gotten them all!

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Jan 16, 2025

Copy link
Copy Markdown
Member

And remove the import sphinx :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Oops!
a601d40
hugovk
hugovk approved these changes Jan 16, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
AA-Turner merged commit d46b577 into python:main Jan 20, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 20, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 20, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
@AA-Turner @miss-islington
pythonGH-125722: Increase minimum supported Sphinx to 8.1.3 (pythonGH…
eba5532 
…-128922)

(cherry picked from commit d46b577)

Co-authored-by: Adam Turner <[email protected]>
@AA-Turner
AA-Turner deleted the docs/sphinx-8-1-3 branch January 20, 2025 00:26
@bedevere-app

bedevere-app Bot commented Jan 20, 2025

Copy link
Copy Markdown

GH-129037 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
@AA-Turner @miss-islington
pythonGH-125722: Increase minimum supported Sphinx to 8.1.3 (pythonGH…
51fbfde 
…-128922)

(cherry picked from commit d46b577)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 20, 2025
@bedevere-app

bedevere-app Bot commented Jan 20, 2025

Copy link
Copy Markdown

GH-129038 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 20, 2025
AA-Turner added a commit that referenced this pull request Jan 20, 2025
@miss-islington @AA-Turner
[3.12] GH-125722: Increase minimum supported Sphinx to 8.1.3 (GH-128922…
6f19c6a 
…) (#129038)

(cherry picked from commit d46b577)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit that referenced this pull request Jan 20, 2025
@miss-islington @AA-Turner
[3.13] GH-125722: Increase minimum supported Sphinx to 8.1.3 (GH-128922…
5fe7650 
…) (#129037)

(cherry picked from commit d46b577)

Co-authored-by: Adam Turner <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
@AA-Turner @srinivasreddy
pythonGH-125722: Increase minimum supported Sphinx to 8.1.3 (python#1…
ee10fc4 
…28922)
@AA-Turner AA-Turner mentioned this pull request Jan 25, 2025
GH-125722: Remove Sphinx patches #129277
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@ezio-melotti ezio-melotti ezio-melotti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AA-Turner @hugovk @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.