GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-129033: Remove _PyInterpreterState_SetConfig() function by vstinner · Pull Request #129048 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jan 20, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Remove _PyInterpreterState_GetConfigCopy() and
_PyInterpreterState_SetConfig() private functions. PEP 741 "Python Configuration C API" added a better public C API: PyConfig_Get() and PyConfig_Set().

  • Issue: Remove _Py_InitializeMain() private function #129033

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner requested a review from ericsnowcurrently as a code owner January 20, 2025 10:08
@bedevere-app bedevere-app Bot mentioned this pull request Jan 20, 2025
Remove _Py_InitializeMain() private function #129033
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 20, 2025
@vstinner
vstinner requested a review from markshannon as a code owner January 20, 2025 11:43
@vstinner
pythongh-129033: Remove _PyInterpreterState_SetConfig() function
27ebb23 
Remove _PyInterpreterState_GetConfigCopy() and
_PyInterpreterState_SetConfig() private functions. PEP 741 "Python
Configuration C API" added a better public C API: PyConfig_Get() and
PyConfig_Set().
@vstinner
vstinner force-pushed the remove_set_config branch from 76a55a6 to 27ebb23 Compare January 20, 2025 12:48
@vstinner

vstinner commented Jan 20, 2025

Copy link
Copy Markdown
Member Author

I got impacted by #129060 issue. I rebased my PR on top of it to fix the issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jan 20, 2025

Copy link
Copy Markdown
Member Author

Oh, test_py_config_isoloated_per_interpreter() of test_capi.test_misc fails with in Free Threaded build:

ImportError: module _testcapi does not support loading in subinterpreters
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Skip test_py_config_isoloated_per_interpreter() on Free Threaded build
0e07d61
@vstinner
vstinner merged commit 8ceb6cb into python:main Jan 20, 2025
@vstinner
vstinner deleted the remove_set_config branch January 20, 2025 15:31
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 20, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
@vstinner @srinivasreddy
pythongh-129033: Remove _PyInterpreterState_SetConfig() function (pyt…
25cfc81 
…hon#129048)

Remove _PyInterpreterState_GetConfigCopy() and
_PyInterpreterState_SetConfig() private functions. PEP 741 "Python
Configuration C API" added a better public C API: PyConfig_Get() and
PyConfig_Set().
youknowone
youknowone reviewed Jul 29, 2025
View reviewed changes
Comment thread Lib/test/support/__init__.py
raise unittest.SkipTest("_testinternalcapi required")
config = _testinternalcapi.get_config()
return not _testcapi.config_get('code_debug_ranges')
return not bool(config['code_debug_ranges'])

@youknowone youknowone Jul 29, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return statement added on Line 511 is shadowing this return.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vstinner vstinner Aug 4, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, well spotted, I created #137379 to remove the dead code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
1 more reviewer
@youknowone youknowone youknowone left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.