GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: fix UBSan failures in `Modules/_sqlite` by picnixz · Pull Request #129087 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jan 20, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 7 commits January 20, 2025 17:42
@picnixz
fix UBSan failures for pysqlite_Blob
3ff8de4
@picnixz
fix UBSan failures for pysqlite_Connection
bc51984
@picnixz
fix UBSan failures for pysqlite_Cursor
280a89f
@picnixz
suppress unused return values
1f3a63c
@picnixz
fix UBSan failures for pysqlite_PrepareProtocol
3806f27
@picnixz
fix UBSan failures for pysqlite_Row
dd99012
@picnixz
fix UBSan failures for pysqlite_Statement
1f54d11
@picnixz picnixz added the skip news label Jan 20, 2025
@picnixz
picnixz requested review from berkerpeksag and erlend-aasland as code owners January 20, 2025 17:01
@bedevere-app bedevere-app Bot mentioned this pull request Jan 20, 2025
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 20, 2025
@picnixz
move cast macros to .c files
63afc08
@encukou encukou added the topic-sqlite3 label Jan 27, 2025
encukou
encukou reviewed Jan 27, 2025
View reviewed changes
Comment thread Modules/_sqlite/row.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
encukou
encukou approved these changes Jan 27, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 27, 2025
@encukou
encukou merged commit 881984b into python:main Jan 31, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 31, 2025
@erlend-aasland

erlend-aasland commented Feb 2, 2025

Copy link
Copy Markdown
Contributor

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz deleted the fix/ubsan/sqlite-111178 branch February 2, 2025 21:51
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@picnixz @srinivasreddy
pythongh-111178: fix UBSan failures in Modules/_sqlite (pythonGH-12…
c79cd63 
…9087)

* fix UBSan failures for `pysqlite_Blob`
* fix UBSan failures for `pysqlite_Connection`
* fix UBSan failures for `pysqlite_Cursor`
* fix UBSan failures for `pysqlite_PrepareProtocol`
* fix UBSan failures for `pysqlite_Row`
* fix UBSan failures for `pysqlite_Statement`

* suppress unused return values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-sqlite3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@picnixz @erlend-aasland @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.