GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-92897: schedule the check_home deprecation to 3.15 by FFY00 · Pull Request #129102 · python/cpython

Conversation

@FFY00

@FFY00 FFY00 commented Jan 20, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Ensure venv works with source builds when using --copies #92897

📚 Documentation preview 📚: https://cpython-previews--129102.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@FFY00
pythonGH-92897: schedule the check_home deprecation to 3.15
25cf141 
Signed-off-by: Filipe Laíns <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Jan 20, 2025
Ensure venv works with source builds when using --copies #92897
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 20, 2025
@FFY00 FFY00 added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes and removed awaiting core review labels Jan 20, 2025
@FFY00
FFY00 enabled auto-merge (squash) January 20, 2025 21:17
@FFY00
FFY00 merged commit e52ab56 into python:main Jan 20, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 20, 2025

Copy link
Copy Markdown

Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jan 20, 2025

Copy link
Copy Markdown

Sorry, @FFY00, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e52ab564da84540a7544cb829f262b0154efccae 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned FFY00 Jan 20, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 20, 2025

Copy link
Copy Markdown

Sorry, @FFY00, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e52ab564da84540a7544cb829f262b0154efccae 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
@FFY00 @srinivasreddy
pythonGH-92897: schedule the check_home deprecation to 3.15 (python#1…
4f6a7f6 
…29102)
@terryjreedy

terryjreedy commented Feb 18, 2025

Copy link
Copy Markdown
Member

If you decided not to backport, please remove labels.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk pushed a commit to hugovk/cpython that referenced this pull request Feb 26, 2025
@FFY00 @hugovk
[3.13] pythonGH-92897: schedule the check_home deprecation to 3.15 (p…
3850b51 
…ythonGH-129102)

(cherry picked from commit e52ab56)

Co-authored-by: Filipe Laíns 🇵🇸 <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 26, 2025

Copy link
Copy Markdown

GH-130583 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 26, 2025
hugovk pushed a commit to hugovk/cpython that referenced this pull request Feb 26, 2025
@FFY00 @hugovk
[3.12] pythonGH-92897: schedule the check_home deprecation to 3.15 (p…
19dfe00 
…ythonGH-129102)

(cherry picked from commit e52ab56)

Co-authored-by: Filipe Laíns 🇵🇸 <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 26, 2025

Copy link
Copy Markdown

GH-130585 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 26, 2025
hugovk
hugovk reviewed Feb 26, 2025
View reviewed changes
Comment thread Doc/deprecations/pending-removal-in-3.15.rst
Comment on lines +56 to +57
* The ``check_home`` argument of :func:`sysconfig.is_python_build` has been
deprecated since Python 3.12.

@hugovk hugovk Feb 26, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove the old deprecation from "Pending removal in future versions":

cpython/Doc/deprecations/pending-removal-in-future.rst

Lines 114 to 115 in 56e1900

* :func:`sysconfig.is_python_build` *check_home* parameter is deprecated and
ignored.

I'll open a new PR to remove it from main, and include it in the backports of this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk hugovk mentioned this pull request Feb 26, 2025
gh-92897: Doc: the check_home removal has been scheduled for 3.15 #130586
Merged
FFY00 added a commit that referenced this pull request Feb 27, 2025
@hugovk @FFY00
[3.13] GH-92897: schedule the check_home deprecation to 3.15 (GH-129102…
4100fb0 
…) (#130583)

Co-authored-by: Filipe Laíns 🇵🇸 <[email protected]>
FFY00 added a commit that referenced this pull request Feb 27, 2025
@hugovk @FFY00
[3.12] GH-92897: schedule the check_home deprecation to 3.15 (GH-129102…
a55a9cd 
…) (#130585)

Co-authored-by: Filipe Laíns 🇵🇸 <[email protected]>
@max-muoto max-muoto mentioned this pull request Dec 26, 2025
Add deprecation for check_home arg of sysconfig.is_python_build python/typeshed#15181
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@FFY00 FFY00

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@FFY00 @terryjreedy @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.