GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — GH-121970: Extract ``pydoc_topics`` into a new extension by AA-Turner · Pull Request #129116 · python/cpython Conversation
|
|
On macOS, The file also reduced from 830 KB to 519 KB. However, I don't have any Python 3.13.1 (v3.13.1:06714517797, Dec 3 2024, 14:00:22) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import runpy >>> topics_old = runpy.run_path("topics_old.py")['topics'] >>> topics_new = runpy.run_path("topics_new.py")['topics'] >>> assert list(topics_old) == list(topics_new) # check order >>> [k for k in topics_old if topics_old[k] != topics_new[k]] [] >>> |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Wonderful! I think I may have been testing with Sphinx 8.1 vs 8.2 (unreleased), as I made a change to how the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
cc @hugovk as 3.14 release manager as this does change the format of
Lib/pydoc_data/topics.py. I'm happy when doing backports to preserve the current format (pformat) if release managers would prefer.
I'm okay with it, but then there are no backports to 3.14 🙃
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ok, let's merge this and then ask @Yhg1s what he thinks about backporting to 3.13 and 3.12. I'm assuming the backports will fail due to the change to A |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @AA-Turner, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @AA-Turner, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Did you decide not to backport? Is so, please remove labels. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I would like to backport; waiting on RM approval (see above). A |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…pythonGH-129116) (cherry picked from commit 01bcf13) Co-authored-by: Adam Turner <[email protected]>
|
GH-130441 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…python#129116) (cherry picked from commit 01bcf13)
…pythonGH-129116) (cherry picked from commit 01bcf13) Co-authored-by: Adam Turner <[email protected]>
|
GH-130443 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
… (#130441) Co-authored-by: Adam Turner <[email protected]>
… (#130443) Co-authored-by: Adam Turner <[email protected]>
python#129116)" This reverts commit 01bcf13.
…ics`` into a new extension (python#129116)" (python#131245)" This reverts commit ca1bedc.
…on (python#129116)" This reverts commit ca1bedc.
…to a new extension (python#129116)" (python#131245) Revert "pythonGH-121970: Extract ``pydoc_topics`` into a new extension (python#129116)" This reverts commit 01bcf13.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.