GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-129248: Filter out the iOS log prefix from testbed runner output. by freakboy3742 · Pull Request #129252 · python/cpython

Conversation

@freakboy3742

@freakboy3742 freakboy3742 commented Jan 24, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Modifies the iOS test runner to strip out the log prefix inserted by the Apple system log.

iOS test logs are gathered by streaming the Apple System log looking for log items from the test process. These log prefixes look like:

2025-01-17 16:14:29.090 Df iOSTestbed[23987:1fd393b4] (Python) ...
2025-01-17 16:14:29.090 E  iOSTestbed[23987:1fd393b4] (Python) ...

The existence of these prefixes was preventing the buildbots from parsing log output to discover test failures. Since the prefix doesn't actually help diagnose issues with the Python test suite, this PR strips out the prefix. This matches what the Android test runner does with ADB log prefixes. It doesn't strip the prefix from the iOS setup/teardown code (the ObjC code that instantiates the XUnit test case, which might be helpful in a diagnostic context, but won't interfere with the Python operation

The acid test for this fix is a test failing and being correctly parsed by the buildbot; that's a little difficult to manufacture, though. For review purposes, you can inspect the test log for the buildbot to see that it matches the test output from other platforms; at which point the buildbot log parser should work as it does on any other platform.

Fixes #129248.

  • Issue: iOS buildbot failure comments don't contain failure details anymore #129248

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@freakboy3742
Filter out the iOS log prefix from testbed runner output.
e6c7195
@freakboy3742 freakboy3742 added OS-ios needs backport to 3.13 only security fixes labels Jan 24, 2025
@freakboy3742
freakboy3742 requested a review from ned-deily January 24, 2025 07:23
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 24, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 24, 2025
iOS buildbot failure comments don't contain failure details anymore #129248
Closed
@freakboy3742

freakboy3742 commented Jan 24, 2025

Copy link
Copy Markdown
Contributor Author

!buildbot iOS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 24, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit e6c7195 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland
StanFromIreland reviewed Jan 24, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Tools-Demos/2025-01-24-14-49-40.gh-issue-129248.JAapG2.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk mentioned this pull request Jan 24, 2025
Link to PR-specific grid in PR message python/buildmaster-config#576
Merged
ned-deily
ned-deily approved these changes Jan 25, 2025
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 25, 2025
@freakboy3742
freakboy3742 merged commit a580838 into python:main Jan 25, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 25, 2025

Copy link
Copy Markdown

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 25, 2025
@freakboy3742
freakboy3742 deleted the ios-log-prefix-strip branch January 25, 2025 08:49
@freakboy3742
freakboy3742 restored the ios-log-prefix-strip branch January 25, 2025 08:49
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 25, 2025
@freakboy3742 @miss-islington
pythongh-129248: Filter out the iOS log prefix from testbed runner ou…
ebcac45 
…tput. (pythonGH-129252)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a580838)

Co-authored-by: Russell Keith-Magee <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 25, 2025

Copy link
Copy Markdown

GH-129283 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 25, 2025
@freakboy3742
freakboy3742 deleted the ios-log-prefix-strip branch January 25, 2025 08:50
freakboy3742 added a commit that referenced this pull request Jan 25, 2025
@miss-islington @freakboy3742
[3.13] gh-129248: Filter out the iOS log prefix from testbed runner o…
aa1beed 
…utput. (GH-129252) (#129283)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a580838)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Mar 16, 2025
@miss-islington @freakboy3742
[3.11] pythongh-129248: Filter out the iOS log prefix from testbed ru…
8db72a8 
…nner output. (pythonGH-129252) (python#129283)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a580838)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Mar 16, 2025
@miss-islington @freakboy3742
[3.10] pythongh-129248: Filter out the iOS log prefix from testbed ru…
fc51691 
…nner output. (pythonGH-129252) (python#129283)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a580838)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Mar 16, 2025
@miss-islington @freakboy3742
[3.9] pythongh-129248: Filter out the iOS log prefix from testbed run…
1a76fcc 
…ner output. (pythonGH-129252) (python#129283)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a580838)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Feb 3, 2026
@miss-islington @freakboy3742
[3.10] pythongh-129248: Filter out the iOS log prefix from testbed ru…
49cd6be 
…nner output. (pythonGH-129252) (python#129283)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a580838)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Feb 3, 2026
@miss-islington @freakboy3742
[3.11] pythongh-129248: Filter out the iOS log prefix from testbed ru…
ac13aae 
…nner output. (pythonGH-129252) (python#129283)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a580838)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Feb 3, 2026
@miss-islington @freakboy3742
[3.12] pythongh-129248: Filter out the iOS log prefix from testbed ru…
db8175f 
…nner output. (pythonGH-129252) (python#129283)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a580838)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Jun 12, 2026
@miss-islington @freakboy3742
[3.11] pythongh-129248: Filter out the iOS log prefix from testbed ru…
d357cb2 
…nner output. (pythonGH-129252) (python#129283)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a580838)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Jun 12, 2026
@miss-islington @freakboy3742
[3.12] pythongh-129248: Filter out the iOS log prefix from testbed ru…
754e747 
…nner output. (pythonGH-129252) (python#129283)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a580838)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Oct 2, 2026
@miss-islington @freakboy3742
[3.12] pythongh-129248: Filter out the iOS log prefix from testbed ru…
649edda 
…nner output. (pythonGH-129252) (python#129283)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a580838)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Oct 2, 2026
@miss-islington @freakboy3742
[3.11] pythongh-129248: Filter out the iOS log prefix from testbed ru…
96a1e26 
…nner output. (pythonGH-129252) (python#129283)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a580838)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Oct 12, 2026
@miss-islington @freakboy3742
[3.12] pythongh-129248: Filter out the iOS log prefix from testbed ru…
292b77f 
…nner output. (pythonGH-129252) (python#129283)

Filter out the iOS log prefix from testbed runner output.
(cherry picked from commit a580838)

Co-authored-by: Russell Keith-Magee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments
@ned-deily ned-deily ned-deily approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

iOS buildbot failure comments don't contain failure details anymore

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@freakboy3742 @bedevere-bot @ned-deily @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.