GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-121970: Remove pyspecific ``PyDecoratorMixin`` patches by AA-Turner · Pull Request #129306 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Jan 26, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Sphinx has supported .. decorator:: and .. decoratormethod since 2011. Though this patch (8a1caa2) has been in the source since 2010 and remained mostly unchanged in the intervening 15 years!

A

  • Issue: Improve and reorganise pyspecific #121970

📚 Documentation preview 📚: https://cpython-previews--129306.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Remove pyspecific PyDecoratorMixin patches
229262c
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jan 26, 2025
@AA-Turner
AA-Turner requested a review from hugovk as a code owner January 26, 2025 03:00
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 26, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 26, 2025
Use the latest Sphinx version #125722
Closed
@AA-Turner
Also remove comment
cc1506d
@AA-Turner AA-Turner changed the title GH-125722: Remove pyspecific PyDecoratorMixin patches GH-121970: Remove pyspecific PyDecoratorMixin patches Jan 26, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 26, 2025
Improve and reorganise pyspecific #121970
Open
@AA-Turner

AA-Turner commented Jan 26, 2025

Copy link
Copy Markdown
Member Author

Markup remains the same:

https://docs.python.org/3/library/abc.html#abc.abstractmethod

https://cpython-previews--129306.org.readthedocs.build/en/129306/library/abc.html#abc.abstractmethod
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner merged commit 0ef8d47 into python:main Jan 26, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 26, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner deleted the docs/rm-PyDecoratorMixin branch January 26, 2025 03:43
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 26, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 26, 2025
@AA-Turner @miss-islington
pythonGH-121970: Remove pyspecific PyDecoratorMixin patches (pyth…
48e14cc 
…onGH-129306)

(cherry picked from commit 0ef8d47)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 26, 2025

Copy link
Copy Markdown

GH-129309 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jan 26, 2025

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0ef8d470b79889de065e94cecd0ee01e45037d3a 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 26, 2025
@miss-islington-app miss-islington-app Bot assigned AA-Turner Jan 26, 2025
@bedevere-app

bedevere-app Bot commented Jan 26, 2025

Copy link
Copy Markdown

GH-129310 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 26, 2025
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Jan 26, 2025
@AA-Turner
[3.12] pythonGH-121970: Remove pyspecific PyDecoratorMixin patches (
a4d3c89 
pythonGH-129306)

(cherry picked from commit 0ef8d47)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit that referenced this pull request Jan 26, 2025
@miss-islington @AA-Turner
[3.13] GH-121970: Remove pyspecific PyDecoratorMixin patches (GH-…
bcececd 
…129306) (#129309)

GH-121970: Remove pyspecific ``PyDecoratorMixin`` patches (GH-129306)
(cherry picked from commit 0ef8d47)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit that referenced this pull request Jan 26, 2025
@AA-Turner
[3.12] GH-121970: Remove pyspecific PyDecoratorMixin patches (GH-…
53204a1 
…129306) (#129310)

(cherry picked from commit 0ef8d47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AA-Turner AA-Turner

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.