GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127146: Update test skips for Emscripten 4.0.2 by hoodmane · Pull Request #129474 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Jan 30, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Emscripten 4.0.2 brought in a few new file system bug fixes.

  • Issue: Emscripten: Get test suite passing #127146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
pythongh-127146: Update test skips for Emscripten 4.0.2
2ef8113
@hoodmane hoodmane added the skip news label Jan 30, 2025
@hoodmane
hoodmane requested review from brettcannon and freakboy3742 as code owners January 30, 2025 12:54
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Jan 30, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 30, 2025
Emscripten: Get test suite passing #127146
Closed
@hoodmane
hoodmane removed the request for review from brettcannon January 30, 2025 12:55
freakboy3742
freakboy3742 requested changes Jan 30, 2025
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fairly straightforward; a couple of small suggestions/questions inline.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_io.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_io.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_io.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels Jan 30, 2025
@bedevere-app

bedevere-app Bot commented Jan 30, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hoodmane added 5 commits January 31, 2025 15:10
@hoodmane
more specific skip reason
b702cf5
@hoodmane
Merge branch 'main' into emscripten-skips-for-4.0.2
d168235
@hoodmane
Rearrange test
29b6115
@hoodmane
Fix
0d187a6
@hoodmane
Fix again
29064d3
freakboy3742
freakboy3742 reviewed Mar 11, 2025
View reviewed changes
Comment thread Lib/test/test_io.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
freakboy3742
freakboy3742 reviewed Mar 11, 2025
View reviewed changes
Comment thread Tools/wasm/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane @freakboy3742
Apply suggestions from code review
827f4d9 
Co-authored-by: Russell Keith-Magee <[email protected]>
@hoodmane

hoodmane commented Mar 15, 2025

Copy link
Copy Markdown
Contributor Author

Okay I applied the suggestions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hoodmane and others added 2 commits March 15, 2025 15:25
@hoodmane
Merge branch 'main' into emscripten-skips-for-4.0.2
3a30031
@freakboy3742
Replace continue with return in inner test method.
27efe76
freakboy3742
freakboy3742 approved these changes Mar 16, 2025
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you missed one (the continue/return change) - but with that merged, looks like everything is working as expected.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting changes labels Mar 16, 2025
@freakboy3742
freakboy3742 merged commit cf288e3 into python:main Mar 16, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 16, 2025
@bedevere-bot

bedevere-bot commented Mar 17, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Refleaks 3.x (tier-2) has failed when building commit cf288e3.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/123/builds/819) and take a look at the build logs.
  4. Check if the failure is related to this commit (cf288e3) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/123/builds/819

Failed tests:

  • test_perf_profiler

Failed subtests:

  • test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 364, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertIn(f"py::foo:{script}", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'py::foo:/tmp/test_python__tl1fx8y/tmplzhea_ps/perftest.py' not found in 'python 3157288 1042537.659911:          1 cycles:Pu: \n\t    ffff98895ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3157288 1042537.659948:          1 cycles:Pu: \n\t    ffff98895ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3157288 1042537.660129:          1 cycles:Pu: \n\t    ffff9889173c <invalid>+0x1d0 (inlined)\n\t    ffff9889173c _dl_start+0x1d0 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff98895ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3157288 1042537.660157:        411 cycles:Pu: \n\t    ffff988917f8 _dl_start+0x28c (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff98895ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3157288 1042537.661149:       3211 cycles:Pu: \n\t    ffff98893440 dl_main+0x1640 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff988905ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff98891b17 _dl_start_final+0x5ab (inlined)\n\t    ffff98891b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff98895ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3157288 1042537.661320:     131419 cycles:Pu: \n\t    ffff98882d0c do_lookup_x+0x8c (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff98883833 _dl_lookup_symbol_x+0x113 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9888f3ef lookup_malloc_symbol+0x3f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff9888f53b __rtld_malloc_init_real+0x77 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff98894003 dl_main+0x2203 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff988905ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff98891b17 _dl_start_final+0x5ab (inlined)\n\t    ffff98891b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff98895ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3157288 1042537.662402:     282500 cycles:Pu: \n\t    ffff9863ee40 getenv+0x40 (/usr/lib64/libc.so.6)\n\t          64d83b config_get_env_dup+0x9f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6511df config_init_env_warnoptions+0x3f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6520e3 config_read_cmdline+0x87 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65305b _PyConfig_Read+0x107 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          672d7f pyinit_core+0xa7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          672e8b Py_InitializeFromConfig+0x97 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a3d5f pymain_init+0xff (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a3e2f pymain_main+0xf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a3ec3 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          41f0b7 main+0xb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t    ffff9862625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff9862633b __libc_start_main@GLIBC_2.17+0x9b (inlined)\n\t          41efaf _start+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 3157288 1042537.664545:    2192925 cycles:Pu: \n\t          55bbfc intern_common+0xe0 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          58e963 _PyUnicode_InternMortal+0x1b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          58ea1f PyUnicode_InternFromString+0x1f (/home/build
-stable-aarch64.refleak/build/python)\n\t          536c57 add_operators+0x5f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          536fb3 type_ready_fill_dict+0x13 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          544523 type_ready+0x93 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5447b3 init_static_type+0x1a7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5448ab _PyStaticType_InitBuiltin+0x23 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5035c3 _PyTypes_InitTypes+0xa7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66ad3f pycore_init_types+0x1b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66b357 pycore_interp_init+0x10b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66b553 pyinit_config+0xaf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          672db3 pyinit_core+0xdb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          672e8b Py_InitializeFromConfig+0x97 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a3d5f pymain_init+0xff (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a3e2f pymain_main+0xf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a3ec3 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          41f0b7 main+0xb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t    ffff9862625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff9862633b __libc_start_main@GLIBC_2.17+0x9b (inlined)\n\t          41efaf _start+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 3157288 1042537.673240:    9873006 cycles:Pu: \n\t          5daf10 PyStackRef_AsPyObjectBorrow+0x4 (inlined)\n\t          5daf10 _PyFrame_GetCode+0x4 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5dcd5b clear_thread_frame+0x23 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5dec23 _PyEval_FrameClearAndPop+0x13 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5fdabf _PyEval_EvalFrameDefault+0x1c767 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          602fbf _PyEval_EvalFrame+0x23 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          60313b _PyEval_Vector+0x11f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4a3493 _PyFunction_Vectorcall+0x6b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4a380f _PyObject_VectorcallTstate+0x5f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4a3a2f _PyObject_CallFunctionVa+0xc3 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4a3ceb callmethod+0x53 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4a3e0f PyObject_CallMethod+0xc7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          64ade3 init_importlib+0xab (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          64b9c3 _PyImport_InitCore+0x2b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66b48f pycore_interp_init+0x243 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66b553 pyinit_config+0xa


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 366, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertIn(f"py::baz:{script}", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'py::baz:/tmp/test_python_htxj4b38/tmpyyj3ka6y/perftest.py' not found in 'python 3261294 1043684.212489:          1 cycles:Pu: \n\t    ffff8d287ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3261294 1043684.212516:          1 cycles:Pu: \n\tffffc95efcdffc78 [unknown] ([unknown])\n\tffffc95efce0049c [unknown] ([unknown])\n\tffffc95efb9a15e4 [unknown] ([unknown])\n\t    ffff8d287ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3261294 1043684.213068:          1 cycles:Pu: \n\t    ffff8d288160 _dlfo_process_initial+0x160 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8d2885ef _dl_find_object_init+0x6f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8d285ff7 dl_main+0x21f7 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8d2825ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8d283b17 _dl_start_final+0x5ab (inlined)\n\t    ffff8d283b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8d287ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 3261294 1043684.213089:        296 cycles:Pu: \n\t    ffff8d287fc0 _dl_find_object_from_map+0x60 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff8d2880e7 _dlfo_process_initial+0xe7 (/usr/lib
.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66accf pycore_init_global_objects+0x23 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66b277 pycore_interp_init+0x2b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66b553 pyinit_config+0xaf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          672db3 pyinit_core+0xdb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          672e8b Py_InitializeFromConfig+0x97 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a3d5f pymain_init+0xff (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a3e2f pymain_main+0xf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a3ec3 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          41f0b7 main+0xb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t    ffff8d01625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff8d01633b __libc_start_main@GLIBC_2.17+0x9b (inlined)\n\t          41efaf _start+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 3261294 1043684.215108:     115224 cycles:Pu: \n\t    ffff8d095d48 strncmp+0x24 (/usr/lib64/libc.so.6)\n\t          5308cf find_signature+0x4b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5309bf _PyType_DocWithoutSignature+0x13 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          536ef7 type_dict_set_doc+0x3f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          536fe3 type_ready_fill_dict+0x43 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          544523 type_ready+0x93 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5447b3 init_static_type+0x1a7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5448ab _PyStaticType_InitBuiltin+0x23 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5035c3 _PyTypes_InitTypes+0xa7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66ad3f pycore_init_types+0x1b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66b357 pycore_interp_init+0x10b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          66b553 pyinit_config+0xaf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          672db3 pyinit_core+0xdb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          672e8b Py_InitializeFromConfig+0x97 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a3d5f pymain_init+0xff (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a3e2f pymain_main+0xf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          6a3ec3 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          41f0b7 main+0xb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t    ffff8d01625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff8d01633b __libc_start_main@GLIBC_2.17+0x9b (inlined)\n\t          41efaf _start+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 3261294 1043684.216058:    1835693 cycles:Pu: \n\t          5077b4 write_size_t+0x1c (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          507aa3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742

freakboy3742 commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

I can't see any reason why this test failure would have been caused by this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane
hoodmane deleted the emscripten-skips-for-4.0.2 branch March 17, 2025 09:27
@hoodmane

hoodmane commented Mar 17, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews @freakboy3742!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
@hoodmane @plashchynski
pythongh-127146: Update test skips for Emscripten 4.0.2 (python#129474)
03a9918 
Updates test skips to reflect capabilities of Emscripten 4.0.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments
@freakboy3742 freakboy3742 freakboy3742 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hoodmane @bedevere-bot @freakboy3742 @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.