GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-128563: Simplify recursion check in `_PyEval_EvalFrameDefault` by markshannon · Pull Request #129481 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Jan 30, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: A new tail-calling interpreter for significantly better interpreter performance #128563

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Simplify recursion check in _PyEval_EvalFrameDefault
c897260
@markshannon markshannon added the skip news label Jan 30, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 30, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 30, 2025
A new tail-calling interpreter for significantly better interpreter performance #128563
Closed
@markshannon
markshannon requested a review from Fidget-Spinner January 31, 2025 11:03
Fidget-Spinner
Fidget-Spinner requested changes Jan 31, 2025
View reviewed changes
Comment thread Python/ceval.c


if (_Py_EnterRecursiveCallTstate(tstate, "")) {
assert(frame->owner != FRAME_OWNED_BY_INTERPRETER);

@Fidget-Spinner Fidget-Spinner Jan 31, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to _Py_LeaveRecursiveCallPy after this as well?

At least from reading the code of exit_unwind.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@markshannon markshannon Jan 31, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. We haven't called _Py_EnterRecursivePy

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting core review labels Jan 31, 2025
@bedevere-app

bedevere-app Bot commented Jan 31, 2025

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon

markshannon commented Jan 31, 2025

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels Jan 31, 2025
@bedevere-app

bedevere-app Bot commented Jan 31, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@Fidget-Spinner: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app
bedevere-app Bot requested a review from Fidget-Spinner January 31, 2025 12:09
Fidget-Spinner
Fidget-Spinner approved these changes Jan 31, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting change review labels Jan 31, 2025
@markshannon
markshannon merged commit c3ae5c9 into python:main Jan 31, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 31, 2025
@markshannon
markshannon deleted the earlier-check-recursion branch January 31, 2025 12:12
mpage added a commit to mpage/cpython that referenced this pull request Feb 1, 2025
@mpage
Revert "pythonGH-128563: Simplify recursion check in `_PyEval_EvalFra…
3edc57c 
…meDefault` (pythonGH-129481)"

This reverts commit c3ae5c9.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@markshannon @srinivasreddy
pythonGH-128563: Simplify recursion check in `_PyEval_EvalFrameDefaul…
433f7df 
…t` (pythonGH-129481)

Simplify recursion check in _PyEval_EvalFrameDefault
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@markshannon @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.