GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-129509: Add required key to the dummy Read the Docs config file by encukou · Pull Request #129510 · python/cpython

Conversation

@encukou

@encukou encukou commented Jan 31, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: 3.9 & 3.10: Read The Docs complains about missing config key #129509

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
pythongh-129509: Add required key to the dummy Read the Docs config file
d922264
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 31, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 31, 2025
3.9 & 3.10: Read The Docs complains about missing config key #129509
Closed
@encukou encukou added the skip news label Jan 31, 2025
@picnixz picnixz added the needs backport to 3.9 label Feb 10, 2025
@picnixz

picnixz commented Feb 10, 2025

Copy link
Copy Markdown
Member

@encukou Actually, I don't know how a backport to 3.9 from a 3.10 branch would be done, so I'll remove the label, but don't forget to backport it to 3.9 since it's blocking 3.9 PRs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz removed the needs backport to 3.9 label Feb 10, 2025
picnixz
picnixz approved these changes Feb 10, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 10, 2025
@YVK49

YVK49 commented Feb 10, 2025

Copy link
Copy Markdown

hi i would like to work on this issue. could you please assign it to me ? looking forward to contributing!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Feb 10, 2025

Copy link
Copy Markdown
Member

We don't assign issues to people and this is a pull request, not an issue. If you want you can make the PR for the 3.9 branch (be careful not to open a PR against main, and be careful to checkout from the 3.9 branch).

For an easier contribution, I would advise looking through issues with the easy label and pick one (usually documentation issues are good first contributions).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Feb 11, 2025

Copy link
Copy Markdown
Member Author

I believe Miss Islington can do the backport just as well as a main one.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou added the needs backport to 3.9 label Feb 11, 2025
@picnixz

picnixz commented Feb 11, 2025

Copy link
Copy Markdown
Member

(Hopefully, we won't have [3.9] [3.10] as the title)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
asvetlov
asvetlov approved these changes Feb 12, 2025
View reviewed changes
hugovk
hugovk approved these changes Feb 18, 2025
View reviewed changes
@hugovk
hugovk merged commit d09105c into python:3.10 Feb 18, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 18, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 18, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 18, 2025
@encukou @miss-islington
[3.10] pythongh-129509: Add required key to the dummy Read the Docs c…
5fd20d2 
…onfig file (pythonGH-129510)

(cherry picked from commit d09105c)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 18, 2025

Copy link
Copy Markdown

GH-130249 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.9 label Feb 18, 2025
hugovk pushed a commit that referenced this pull request Feb 18, 2025
@miss-islington @encukou
[3.9] gh-129509: Add required key to the dummy Read the Docs config f…
474f3d3 
…ile (GH-129510) (#130249)

Co-authored-by: Petr Viktorin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes
@hugovk hugovk hugovk approved these changes
@picnixz picnixz picnixz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@encukou @picnixz @YVK49 @asvetlov @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.