GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "gh-129005: Align FileIO.readall() allocation (#129458)" by cmaloney · Pull Request #129572 · python/cpython

Conversation

@cmaloney

@cmaloney cmaloney commented Feb 2, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This reverts commit f927204.

@vstinner : Should get the buildbots back green, then can work on new features like bytearray.resize(). Feels like I’ve been rushing digging more holes rather than get all green.

  • Issue: Reduce copies when reading files in pyio, match behavior of _io #129005

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cmaloney
Revert "pythongh-129005: Align FileIO.readall() allocation (python#12…
eb3aa4b 
…9458)"

This reverts commit f927204.
@bedevere-app bedevere-app Bot added the awaiting review label Feb 2, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 2, 2025
Reduce copies when reading files in pyio, match behavior of _io #129005
Closed
@vstinner
vstinner merged commit 853a6b7 into python:main Feb 2, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 2, 2025
@vstinner

vstinner commented Feb 2, 2025

Copy link
Copy Markdown
Member

Merged, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cmaloney
cmaloney deleted the cmaloney/buildbot_fix_revert branch February 2, 2025 16:49
@cmaloney

cmaloney commented Feb 2, 2025

Copy link
Copy Markdown
Contributor Author

Multiple bots which were failing on test now passing, remaining ones seem to be heading to green as they catch up to main. Thanks!
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@cmaloney @srinivasreddy
Revert "pythongh-129005: Align FileIO.readall() allocation (python#12…
cee0ebc 
…9458)" (python#129572)

This reverts commit f927204.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cmaloney @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.