GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-121970: Extract ``misc_news`` into a new extension by AA-Turner · Pull Request #129577 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Feb 2, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This removes the PY_MISC_NEWS_DIR environment variable, which was only set/used in make.bat. I've synchronised it with the Makefile, where we always use build/.

I considered removing the relative path handling, and changing the file argument of the .. miscnews:: directive to be relative to the Sphinx confdir (i.e. changing to .. miscnews:: build/NEWS), which would somewhat simplify things, but that could be a follow-up.

A

  • Issue: Improve and reorganise pyspecific #121970

📚 Documentation preview 📚: https://cpython-previews--129577.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Extract misc_news into a new extension
3a01a73
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Feb 2, 2025
@AA-Turner
AA-Turner requested a review from hugovk as a code owner February 2, 2025 12:57
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 2, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 2, 2025
Improve and reorganise pyspecific #121970
Open
picnixz
picnixz reviewed Feb 2, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments/questions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/tools/extensions/misc_news.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/tools/extensions/misc_news.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/tools/extensions/misc_news.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Bénédikt's comments
6f3cb21
@AA-Turner
AA-Turner requested a review from picnixz February 2, 2025 15:07
picnixz
picnixz approved these changes Feb 2, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. By the way, for what reason are we changing the "what's new in ...?" text ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 2, 2025
@AA-Turner

AA-Turner commented Feb 2, 2025

Copy link
Copy Markdown
Member Author

(?im) is the same as re.I | re.M: https://docs.python.org/3/library/re.html#index-16
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Feb 2, 2025

Copy link
Copy Markdown
Member

Ah no, I meant: Why is the "What's new in ..." sentences not correct? Namely why are we modifying these parts of the text?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Feb 2, 2025

Copy link
Copy Markdown
Member Author

Blurb outputs "What's New in " before each heading, which we strip for the rendered changelog. Perhaps we should modify Blurb not to do so.
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner AA-Turner mentioned this pull request Feb 2, 2025
Produce better Misc/NEWS output for Sphinx python/blurb#44
Open
@AA-Turner
Strip blurb "Python News" header
7b4aa2a
@AA-Turner
AA-Turner merged commit ae47888 into python:main Feb 2, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 2, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner deleted the docs/miscnews branch February 2, 2025 16:17
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 2, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 2, 2025

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ae4788809d674f8e27faef2678953be8cf67d4a3 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned AA-Turner Feb 2, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 2, 2025

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ae4788809d674f8e27faef2678953be8cf67d4a3 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Feb 2, 2025

Copy link
Copy Markdown

GH-129586 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 2, 2025
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Feb 2, 2025
@AA-Turner
[3.13] pythonGH-121970: Extract misc_news into a new extension (p…
6cd489d 
…ythonGH-129577)

(cherry picked from commit ae47888)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Feb 2, 2025
@AA-Turner
pythonGH-121970: Extract misc_news into a new extension (python#1…
4c343cd 
…29577)

(cherry picked from commit ae47888)
@bedevere-app

bedevere-app Bot commented Feb 2, 2025

Copy link
Copy Markdown

GH-129587 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 2, 2025
@bedevere-app

bedevere-app Bot commented Feb 2, 2025

Copy link
Copy Markdown

GH-129587 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner added a commit that referenced this pull request Feb 2, 2025
@AA-Turner
[3.13] GH-121970: Extract misc_news into a new extension (GH-129577…
63cae73 
…) (#129586)

(cherry picked from commit ae47888)
AA-Turner added a commit that referenced this pull request Feb 2, 2025
@AA-Turner
[3.12] GH-121970: Extract misc_news into a new extension (GH-129577…
834b9d6 
…) (#129587)

(cherry picked from commit ae47888)
@hugovk

hugovk commented Feb 2, 2025

Copy link
Copy Markdown
Member

This removes the PY_MISC_NEWS_DIR environment variable, which was only set/used in make.bat. I've synchronised it with the Makefile, where we always use build/.

cc @zooba: PY_MISC_NEWS_DIR was first added in afe17a7 -- do you still use it elsewhere?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner AA-Turner mentioned this pull request Feb 3, 2025
Misc\NEWS in the Windows installer python/release-tools#213
Closed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@AA-Turner @srinivasreddy
pythonGH-121970: Extract misc_news into a new extension (python#1…
78e48a4 
…29577)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AA-Turner AA-Turner

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AA-Turner @picnixz @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.